Set additionalPrinterColumns for UpdateService CRD #138

DavidHurta · 2021-12-13T14:53:23Z

Set additionalPrinterColumns for UpdateService CRD to provide more information to a user about the UpdateService resource.

Previously running the oc get -o wide ... command only displayed the name and the age of the specific running UpdateService resources.

Display the policyEngineURI, releases, graphDataImage, and the ReconcileCompleted condition status to provide more information to a user about the UpdateService resource. Set the priority of these additionalPrinterColumns accordingly to list them only when the -o wide flag is provided.

Pull request is related to https://issues.redhat.com/browse/OTA-449

DavidHurta · 2021-12-13T15:45:02Z

/hold
The Age column is no longer displayed. I need to fix that.

Add additionalPrinterColumns to the UpdateService custom resource definition file. Previously running the "oc get -o wide ..." command only displayed the name and the age of the specific running UpdateService resources. Display the policyEngineURI, releases, graphDataImage, and the ReconcileCompleted condition status to provide more information to a user about the UpdateService resource. Set the priority of these additionalPrinterColumns to 1 to list them only when the "-o wide" flag is provided.

DavidHurta · 2021-12-13T16:06:06Z

/unhold
Fixed the issue mentioned in #138 (comment) in the new commit bf6d5e5.

DavidHurta · 2021-12-13T16:16:41Z

An example of the output when running the command oc get -n openshift-update-service -o wide updateservice:

NAME     AGE   POLICY ENGINE URI                                                                                                        RELEASES                                    GRAPH DATA IMAGE   RECONCILE COMPLETED
sample   21m   https://sample-policy-engine-route-openshift-update-service.apps.ci-ln-bmq9sy2-72292.origin-ci-int-gce.dev.rhcloud.com   quay.io/openshift-release-dev/ocp-release   example.com        True

Note: Some of the columns are only proposed as an idea in https://issues.redhat.com/browse/OTA-449 for the additionalPrinterColumns.

wking

/lgtm

openshift-ci · 2021-12-13T21:48:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Davoska, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wking · 2021-12-13T21:52:21Z

operator-e2e spent 10m waiting for the Cincinnati pod:

I1213 16:43:24.307556    5641 utils.go:86] updateservice.updateservice.operator.openshift.io/example created
I1213 16:43:54.386944    5641 utils.go:106] Waiting for full availability of example deployment (0/1)
...
I1213 16:53:24.422388    5641 utils.go:106] Waiting for full availability of example deployment (0/1)
    updateservice_creation_test.go:81: timed out waiting for the condition

We should probably update the test suite to dump pod status if that happens, but I don't see how it could be related to this CRD change, so:

/retest

Poking at events, looks like we're permafailing on readiness probe 503s:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_cincinnati-operator/138/pull-ci-openshift-cincinnati-operator-master-operator-e2e/1470424053910081536/artifacts/operator-e2e/gather-extra/artifacts/events.json | jq -r '.items | sort_by(.metadata.creationTimestamp)[] | select(.metadata.namespace == "openshift-updateservice") | .metadata.creationTimestamp + " " + (.count | tostring) + " " + .reason + ": " + .message' | tail -n4
2021-12-13T16:43:39Z 34 ProbeError: Readiness probe error: HTTP probe failed with statuscode: 503
body: 

2021-12-13T16:43:39Z 7 Unhealthy: Readiness probe failed: HTTP probe failed with statuscode: 503

openshift-bot · 2021-12-14T00:29:19Z

/retest-required