Skip to content

Conversation

@ngopalak-redhat
Copy link
Contributor

@ngopalak-redhat ngopalak-redhat commented Nov 7, 2025

Fixes: #OCPNODE-3722
This change introduces a gate to block 4.20 clusters from upgrading to 4.21 until the prerequisite patch for Auto Node Sizing has been applied.

Context: Clusters created before 4.21 must have Auto Node Sizing disabled by default.

Requirement: The necessary 4.20 patch openshift/machine-config-operator#5387 introduces a specific MachineConfig to enforce this disabled state.

Goal: This PR ensures upgrade safety by confirming the presence of that MachineConfig before proceeding to 4.21.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ngopalak-redhat ngopalak-redhat changed the title Set minimum version of 4.20 required to upgrade to 4.21 OCPNODE-3722: Set minimum version of 4.20 required to upgrade to 4.21 Nov 7, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2025

@ngopalak-redhat: This pull request references OCPNODE-3722 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20.z" instead.

Details

In response to this:

Fixes: #OCPNODE-3722
This change introduces a gate to block 4.20 clusters from upgrading to 4.21 until the prerequisite patch for Auto Node Sizing has been applied.

Context: Clusters created before 4.21 must have Auto Node Sizing disabled by default.

Requirement: The necessary 4.20 patch openshift/machine-config-operator#5387 introduces a specific MachineConfig to enforce this disabled state.

Goal: This PR ensures upgrade safety by confirming the presence of that MachineConfig before proceeding to 4.21.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2025

@ngopalak-redhat: This pull request references OCPNODE-3722 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20.z" instead.

Details

In response to this:

Fixes: #OCPNODE-3722
This change introduces a gate to block 4.20 clusters from upgrading to 4.21 until the prerequisite patch for Auto Node Sizing has been applied.

Context: Clusters created before 4.21 must have Auto Node Sizing disabled by default.

Requirement: The necessary 4.20 patch openshift/machine-config-operator#5387 introduces a specific MachineConfig to enforce this disabled state.

Goal: This PR ensures upgrade safety by confirming the presence of that MachineConfig before proceeding to 4.21.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ngopalak-redhat
Copy link
Contributor Author

/hold Until openshift/machine-config-operator#5387 is merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2025
@ngopalak-redhat ngopalak-redhat marked this pull request as ready for review November 7, 2025 12:48
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2025
@ngopalak-redhat
Copy link
Contributor Author

@haircommander @sairameshv please review. I have kept it on hold so that 4.20 PR can be merged

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2025
@ngopalak-redhat ngopalak-redhat force-pushed the ngopalak/auto-node-min-version branch from 13507e8 to f72077e Compare November 20, 2025 06:02
@coderabbitai
Copy link

coderabbitai bot commented Nov 20, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 20, 2025
@ngopalak-redhat
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2025
@ngopalak-redhat
Copy link
Contributor Author

cc: @haircommander @sairameshv

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 20, 2025
@ngopalak-redhat
Copy link
Contributor Author

/hold Wait will 4.20.5 build is made.

@ngopalak-redhat ngopalak-redhat force-pushed the ngopalak/auto-node-min-version branch from f72077e to a8316c3 Compare November 27, 2025 13:31
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@ngopalak-redhat
Copy link
Contributor Author

@wking and @sairameshv Can you review and remove hold on this PR? Updated the version number to 4.20.6 https://amd64.ocp.releases.ci.openshift.org/releasestream/4-stable/release/4.20.6

@sairameshv
Copy link
Member

/lgtm
/hold cancel

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 27, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2025

@ngopalak-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Nov 28, 2025

/retitle Set minimum version of 4.20 required to upgrade to 4.21

@openshift-ci openshift-ci bot changed the title OCPNODE-3722: Set minimum version of 4.20 required to upgrade to 4.21 Set minimum version of 4.20 required to upgrade to 4.21 Nov 28, 2025
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 28, 2025
@openshift-ci-robot
Copy link

@ngopalak-redhat: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Fixes: #OCPNODE-3722
This change introduces a gate to block 4.20 clusters from upgrading to 4.21 until the prerequisite patch for Auto Node Sizing has been applied.

Context: Clusters created before 4.21 must have Auto Node Sizing disabled by default.

Requirement: The necessary 4.20 patch openshift/machine-config-operator#5387 introduces a specific MachineConfig to enforce this disabled state.

Goal: This PR ensures upgrade safety by confirming the presence of that MachineConfig before proceeding to 4.21.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson
Copy link
Member

sdodson commented Nov 28, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ngopalak-redhat, sairameshv, sdodson
Once this PR has been reviewed and has the lgtm label, please assign hongkailiu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson sdodson merged commit 6a3d66d into openshift:master Nov 28, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants