-
Notifications
You must be signed in to change notification settings - Fork 65
Set minimum version of 4.20 required to upgrade to 4.21 #8277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set minimum version of 4.20 required to upgrade to 4.21 #8277
Conversation
|
Skipping CI for Draft Pull Request. |
|
@ngopalak-redhat: This pull request references OCPNODE-3722 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20.z" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@ngopalak-redhat: This pull request references OCPNODE-3722 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.21." or "openshift-4.21.", but it targets "openshift-4.20.z" instead. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold Until openshift/machine-config-operator#5387 is merged |
|
@haircommander @sairameshv please review. I have kept it on hold so that 4.20 PR can be merged |
13507e8 to
f72077e
Compare
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Comment |
|
/hold cancel |
|
/hold Wait will 4.20.5 build is made. |
f72077e to
a8316c3
Compare
|
@wking and @sairameshv Can you review and remove hold on this PR? Updated the version number to 4.20.6 https://amd64.ocp.releases.ci.openshift.org/releasestream/4-stable/release/4.20.6 |
|
/lgtm |
|
@ngopalak-redhat: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retitle Set minimum version of 4.20 required to upgrade to 4.21 |
|
@ngopalak-redhat: No Jira issue is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ngopalak-redhat, sairameshv, sdodson The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes: #OCPNODE-3722
This change introduces a gate to block 4.20 clusters from upgrading to 4.21 until the prerequisite patch for Auto Node Sizing has been applied.
Context: Clusters created before 4.21 must have Auto Node Sizing disabled by default.
Requirement: The necessary 4.20 patch openshift/machine-config-operator#5387 introduces a specific MachineConfig to enforce this disabled state.
Goal: This PR ensures upgrade safety by confirming the presence of that MachineConfig before proceeding to 4.21.