Skip to content

Conversation

@steveej
Copy link
Contributor

@steveej steveej commented Feb 24, 2020

The metadata in this has been manually added on quay in the past. It's
my understanding that we don't plan to a convenient mapping for adding
edges using previous.add, so we don't want a convenience structure for
this.


This is part of openshift/cincinnati#226.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 24, 2020
@steveej steveej force-pushed the pr/raw-metadata branch 3 times, most recently from 33436f7 to 1571d1e Compare February 24, 2020 20:33
The metadata in this has been manually added on quay in the past.  It's
my understanding that we don't plan to a convenient mapping for adding
edges using `previous.add`, so we don't want a convenience structure for
this.
@wking wking changed the title raw_metadata.json: add historical metadata from quay raw/metadata.json: add historical metadata from quay Feb 24, 2020
@wking
Copy link
Member

wking commented Feb 24, 2020

For context, we need these post-release edge injections to preserve this portion of the prerelease-4.1 Cincinnati graph:

Screenshot from 2020-02-24 11-13-55

because those edges are not included in the release image metadata (which is our current best-practice):

$ for TAG in 4.1.0-rc.6 4.1.0-rc.7 4.1.0-rc.9 4.1.0; do echo -ne "${TAG}\t"; oc adm release info "quay.io/openshift-release-dev/ocp-release:${TAG}" | grep Upgrades; done
4.1.0-rc.6	  Upgrades: <none>
4.1.0-rc.7	  Upgrades: <none>
4.1.0-rc.9	  Upgrades: <none>
4.1.0	  Upgrades: <none>

/lgtm

(but will need a release admin to approve).

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 24, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: steveeJ, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Feb 24, 2020

...(but will need a release admin to approve).

or not, because @steveej was authorized to approve the change being made by the initial PR? Or because he's allowed to create new directories that get delegated to other approvers? Or something like that.

@openshift-merge-robot openshift-merge-robot merged commit b3d416f into openshift:master Feb 24, 2020
@steveej steveej deleted the pr/raw-metadata branch February 24, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants