Skip to content

channels/stable-4.2: 4.2.20 to stable #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Feb 28, 2020
Merged

channels/stable-4.2: 4.2.20 to stable #68

openshift-merge-robot merged 1 commit into from
Feb 28, 2020

Conversation

@thiagoalessio
Copy link
Member

@thiagoalessio thiagoalessio commented Feb 21, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2020
@vrutkovs
Copy link

vrutkovs commented Feb 21, 2020

/hold

Depends on #67

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020
@eparis
Copy link
Member

eparis commented Feb 21, 2020

/approve
/hold
but should it be in stable-4.3 as well?

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2020
@eparis
Copy link
Member

eparis commented Feb 24, 2020

/approve cancel
I think this should go into stable-4.3 at the same time (but only the amd64 version)

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 24, 2020
@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Feb 28, 2020 •
edited
Loading

I think this should go into stable-4.3 at the same time (but only the amd64 version)

The plan was to introduce 4.2 builds in stable-4.3 after 4.3.3 but now has blocker issues we have to wait for 4.3.5

LalatenduMohanty
LalatenduMohanty approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@eparis
Copy link
Member

eparis commented Feb 28, 2020

/approve
/hold cancel

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 28, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@eparis
Copy link
Member

eparis commented Feb 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, LalatenduMohanty, thiagoalessio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 18fcca5 into openshift:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crawford crawford Awaiting requested review from crawford

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

1 more reviewer

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LalatenduMohanty LalatenduMohanty

@eparis eparis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@thiagoalessio @vrutkovs @eparis @LalatenduMohanty @openshift-ci-robot @openshift-merge-robot