Skip to content

Conversation

@openshift-bot
Copy link
Contributor

Please merge within 48 hours of https://errata.devel.redhat.com/advisory/69871 shipping live OR a Cincinnati-first release.

This should provide adequate soak time for fast channel PR #674

This PR will also enable upgrades from 4.6.20 to releases in stable-4.7

@openshift-bot openshift-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2021
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2021
@vrutkovs
Copy link

Approving stable PRs after 48 hours
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 11, 2021
@wking
Copy link
Member

wking commented Mar 13, 2021

Should get EUS, etc.

@wking wking force-pushed the pr-stable-4.6.20 branch from 9ff9bb6 to 55830fd Compare March 15, 2021 17:51
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 15, 2021
@wking
Copy link
Member

wking commented Mar 15, 2021

Rebased and added EUS with 9ff9bb6 -> 55830fd.

/lgtm

@wking wking closed this Mar 15, 2021
@wking wking reopened this Mar 15, 2021
@vrutkovs
Copy link

Approving stable PRs after 48 hours
/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-bot, vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2021
@wking
Copy link
Member

wking commented Mar 15, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1359db4 into master Mar 15, 2021
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Mar 16, 2021
Like 1fb8768 (Add 4.5 to 4.6 upgrades to stable-4.6, 2020-12-14,
4.7.1) when rebasing 55830fd (Enable 4.6.20 in stable and EUS
channel(s), 2021-03-03, openshift#675), but we're happy with the 4.6->4.7
stability, and ready to put the rest of these in stable-4.7 anyway.
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Mar 16, 2021
Like 1fb8768 (Add 4.5 to 4.6 upgrades to stable-4.6, 2020-12-14, openshift#585).
Id forgotten to drop 4.6.20 (and its edge to 4.7.1) from stable-4.7
when rebasing 55830fd (Enable 4.6.20 in stable and EUS channel(s),
2021-03-03, openshift#675), but we're happy with the 4.6->4.7 stability, and
ready to put the rest of these in stable-4.7 anyway.
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Mar 30, 2021
Like 1fb8768 (Add 4.5 to 4.6 upgrades to stable-4.6, 2020-12-14, openshift#585).
Id forgotten to drop 4.6.20 (and its edge to 4.7.1) from stable-4.7
when rebasing 55830fd (Enable 4.6.20 in stable and EUS channel(s),
2021-03-03, openshift#675), but we're happy with the 4.6->4.7 stability, and
ready to put the rest of these in stable-4.7 anyway.
@wking wking deleted the pr-stable-4.6.20 branch April 22, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants