Skip to content

Conversation

@thiagoalessio
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2020
@wking
Copy link
Member

wking commented Feb 21, 2020

/hold

Blocked on fast in #64

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2020
@eparis
Copy link
Member

eparis commented Feb 21, 2020

/approve
/hold

@eparis
Copy link
Member

eparis commented Feb 21, 2020

does it belong in stable-4.3?

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2020
@vrutkovs
Copy link

Blocked by #64 (fast-4.2)

@eparis
Copy link
Member

eparis commented Feb 24, 2020

/approve cancel
I think this should go into stable-4.3 at the same time

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 24, 2020
@LalatenduMohanty
Copy link
Member

#64 is merged now. @thiagoalessio Can you rebase this PR?

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 25, 2020
@LalatenduMohanty
Copy link
Member

@eparis It is in https://github.com/openshift/cincinnati-graph-data/blob/master/channels/fast-4.3.yaml#L8 but not in stable-4.3 as we do not have any 4.2 release in stable-4.3

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Feb 26, 2020

/lgtm
Checked telemetry for upgrades from 4.1.34, 4.2.18, 4.2.16

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
@eparis
Copy link
Member

eparis commented Feb 27, 2020

Why are there no 4.2 releases in 4.3-stable?

@LalatenduMohanty
Copy link
Member

Why are there no 4.2 releases in 4.3-stable?

We have not enabled edges in stable because of https://github.com/openshift/cincinnati-graph-data/blob/master/blocked-edges/4.3.0.yaml#L4

@eparis
Copy link
Member

eparis commented Feb 28, 2020

/approve
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, LalatenduMohanty, thiagoalessio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit a0c2dce into openshift:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants