Skip to content

Conversation

@openshift-bot
Copy link
Contributor

Please merge within 48 hours of https://errata.devel.redhat.com/advisory/69477 shipping live OR a Cincinnati-first release.

This should provide adequate soak time for fast channel PR #658

@openshift-bot openshift-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 17, 2021
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 21, 2021
@vrutkovs
Copy link

Approving stable PRs after 48 hours
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 24, 2021
@wking wking force-pushed the pr-stable-4.6.18 branch from 5683738 to e44c842 Compare March 2, 2021 16:31
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 2, 2021
@wking
Copy link
Member

wking commented Mar 2, 2021

Rebased around #654 with 5683738 -> e44c842.

/lgtm

@vrutkovs
Copy link

vrutkovs commented Mar 2, 2021

Approving stable PRs after 48 hours
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-bot, vrutkovs, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Mar 2, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit 885d3f0 into master Mar 2, 2021
@wking wking deleted the pr-stable-4.6.18 branch April 22, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants