Skip to content

Conversation

@petr-muller
Copy link
Member

@petr-muller petr-muller commented Dec 6, 2024

Address SDN-5485 / OCPBUGS-43454 which affects 4.17 until 4.17.7 where it is fixed. We have not managed to identify a precise technical PromQL to identify clusters with the exact problematic networking configuration so I am proposing to use a coarse approximation of what clusters are likely (based on the information available) to have such config (OpenShift Virtualization installations identified by the hyperconverged-cluster-operator CSV presence, and which at the same time have at least one network-attachment-definitions.k8s.cni.cncf.io resource instance.

Given the impact of the bug when hit (failure to create new workloads), it is better to steer the group of potentially affected clusters towards already available 4.17.7, even if we are not able to produce a sufficiently targeted PromQL for the actual network configuration.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@petr-muller petr-muller force-pushed the OVNLocalnetWithNoSubnets branch from f3718a1 to b0a6e0f Compare December 6, 2024 13:43
@petr-muller petr-muller changed the title OVNLocalnetWithNoSubnets: ->4.17.[0-6] with virtualization SDN-5485: OVNLocalnetWithNoSubnets: ->4.17.[0-6] with virtualization Dec 6, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2024

@petr-muller: This pull request references SDN-5485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Address SDN-5485 / OCPBUGS-43454 which affects 4.17 until 4.17.7 where
it is fixed. We have not managed to identify a precise technical PromQL
to identify clusters with the exact problematic networking configuration
so I am proposing to use a coarse approximation of what clusters are
likely (based on the information available) to have such config (OpenShift
Virtualization installations identified by the hyperconverged-cluster-operator
CSV presence.

Given the impact of the bug when hit (failure to create new workloads),
it is better to steer the group of potentially affected clusters towards
already available 4.17.7, even if we are not able to produce a sufficiently
targeted PromQL for the actual network configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Address SDN-5485 / OCPBUGS-43454 which affects 4.17 until 4.17.7 where
it is fixed. We have not managed to identify a precise technical PromQL
to identify clusters with the exact problematic networking configuration
so I am proposing to use a coarse approximation of what clusters are
*likely* (based on the information available) to have such config (OpenShift
Virtualization installations identified by the hyperconverged-cluster-operator
CSV presence, which at the same time have at least one `network-attachment-definitions.k8s.cni.cncf.io`
resource instance.

Given the impact of the bug when hit (failure to create new workloads),
it is better to steer the group of potentially affected clusters towards
already available 4.17.7, even if we are not able to produce a sufficiently
targeted PromQL for the actual network configuration.
@petr-muller petr-muller force-pushed the OVNLocalnetWithNoSubnets branch from b0a6e0f to 79f8eb4 Compare December 6, 2024 19:11
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 6, 2024

@petr-muller: This pull request references SDN-5485 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Address SDN-5485 / OCPBUGS-43454 which affects 4.17 until 4.17.7 where it is fixed. We have not managed to identify a precise technical PromQL to identify clusters with the exact problematic networking configuration so I am proposing to use a coarse approximation of what clusters are likely (based on the information available) to have such config (OpenShift Virtualization installations identified by the hyperconverged-cluster-operator CSV presence, and which at the same time have at least one network-attachment-definitions.k8s.cni.cncf.io resource instance.

Given the impact of the bug when hit (failure to create new workloads), it is better to steer the group of potentially affected clusters towards already available 4.17.7, even if we are not able to produce a sufficiently targeted PromQL for the actual network configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

@petr-muller: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 05183cb into openshift:master Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants