Skip to content

WIP: hack/graph-util: Add 'print' to write JSON to stdout #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wking wants to merge 1 commit into from
Closed

WIP: hack/graph-util: Add 'print' to write JSON to stdout #47

wking wants to merge 1 commit into from

Conversation

@wking
Copy link
Member

@wking wking commented Feb 7, 2020 •
edited
Loading

To allow:

$ hack/graph-util.py print >graph.json

to dump our assembled metadata to disk, as an alternative to passing it to Cincinnati via Quay labels.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 7, 2020
@wking wking changed the title hack/graph-util: Add push-to-disk WIP: hack/graph-util: Add push-to-disk Feb 7, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 7, 2020
@wking wking changed the title WIP: hack/graph-util: Add push-to-disk WIP: hack/graph-util: Add 'print' to write JSON to stdout Feb 7, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2020
@wking
hack/graph-util: Add 'print' to write JSON to stdout
17d6444 
To allow:

  $ hack/graph-util.py print >graph.json

to dump our assembled metadata to disk, as an alternative to passing
it to Cincinnati via Quay labels.
@eparis
Copy link
Member

eparis commented Feb 14, 2020

/lgtm
How hard would a printer be that gave Cincinnati compatible outputs?

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 24, 2020

@wking: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member Author

wking commented Feb 25, 2020

/close

Stefan is going to grow a graph-builder plugin to parse this Git repo directly: openshift/cincinnati#231.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 25, 2020

@wking: Closed this PR.

Details

In response to this:

/close

Stefan is going to grow a graph-builder plugin to parse this Git repo directly: openshift/cincinnati#231.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the push-to-disk branch February 25, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwforres jwforres Awaiting requested review from jwforres

@lucab lucab Awaiting requested review from lucab

Assignees

@eparis eparis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wking @eparis @openshift-ci-robot