blocked-edges/4.14.0-ConsoleImplicitlyEnabled: Drop conditional risk from 4.13 again #4339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from 4.13 again Repeating 897f57f (blocked-edges/4.14.0-ConsoleImplicitlyEnabled: Drop conditional risk from 4.13, 2023-10-31, openshift#4326). I'd thought the tuned 'from' regular expressions in 361e132 (blocked-edges/4.14.*-ConsoleImplicitlyEnabled: Tune from versions, 2023-11-01, openshift#4337) would avoid the issue, but apparently not: $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?arch=amd64&channel=fast-4.14' | jq -r '.nodes[] | select(.version == "4.14.0").metadata["io.openshift.upgrades.graph.previous.remove_regex"]' 4[.](13[.]19|14[.]0-(ec[.].*|rc[.][01])) showing Cincinnati using the 'from' from the ConsoleImplicitlyEnabled, and apparently forgetting about the silent-drop from 4.14.0.yaml: $ hack/show-edges.py --cincinnati https://api.openshift.com/api/upgrades_info/graph --root-version 4.13.17 fast-4.14 4.13.17 -> 4.13.18 4.13.17 -> 4.13.19 4.13.17 -> 4.14.0 # this unqualified recommendation misses the mutated-SCC guard from 4.14.0.yaml 4.13.18 -> 4.13.19 4.13.18 -> 4.14.0 # this unqualified recommendation misses the mutated-SCC guard from 4.14.0.yaml 4.13.19 -(risks: ConsoleImplicitlyEnabled)-> 4.14.0 # we'd like to keep this 4.13.19 -(risks: ConsoleImplicitlyEnabled)-> 4.14.1 4.14.0 -> 4.14.1 This commit is expected to transition us to: $ hack/show-edges.py --root-version 4.13.17 fast-4.14 4.13.17 -> 4.13.18 4.13.17 -> 4.13.19 4.13.17 -(SILENT-BLOCK)-> 4.14.0 # better than the current unqualified recommendation 4.13.18 -> 4.13.19 4.13.18 -(SILENT-BLOCK)-> 4.14.0 # better than the current unqualified recommendation 4.13.19 -> 4.14.0 # we'd like this to mention ConsoleImplicitlyEnabled, but I'm back to not knowing how to get that to happen 4.13.19 -(risks: ConsoleImplicitlyEnabled)-> 4.14.1 4.14.0 -> 4.14.1
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Member
Author
|
Self-LGTMing, like I did for the previous round. |
petr-muller
added a commit
to petr-muller/cincinnati-graph-data
that referenced
this pull request
May 9, 2024
Generated with https://github.com/petr-muller/ota/tree/main/cmd/graph-extend-or-fix by basically extending backwards: ```console for risk in AWSCustomDomainNodesNotReady AWSECRLegacyCredProvider AzureDefaultVMType AzureRegistryImagePreservation ConsoleImplicitlyEnabled IngressDegradedOnRouterReloads go run ./cmd/graph-extend-or-fix/... --jira-endpoint=https://issues.redhat.com --jira-bearer-token-file=$HOME/Temporary/jira-upgradeblocker-token --graph-repository-path=/home/pmuller/Projects/RH/github.com/openshift/cincinnati-graph-data --risk=$risk --last=4.14.1 --new=4.14.0 --do=extend end ``` I have not included the formatting changes in AWSCustomDomainNodesNotReady and IngressDegradedOnRouterReloads that already existed on 4.14.0 Initially we wanted to silently drop the 4.14.0 release from the graph but because of [OTA-1043](https://issues.redhat.com/browse/OTA-1043) it is hard to keep it that way, because we usually automate adding new 4.14 risks over individual patch updates and forget to avoid adding one for 4.14.0. This way we struggle to keep the drop in effect (see openshift#4339 and openshift#4301), so we decided to give up and just bury 4.14.0 in conditional risks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeating 897f57f (#4326). I'd thought the tuned 'from' regular expressions in 361e132
(#4337) would avoid the issue, but apparently not:
showing Cincinnati using the
fromfrom theConsoleImplicitlyEnabled, and apparently forgetting about the silent-drop from4.14.0.yaml:This commit is expected to transition us to: