Do not add 4.2 s390 release to 4.3 channels #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eparis, jwforres The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
Member
Author
|
I added comments to the files. So I manually re-lgtm'd it. |
wking
referenced
this pull request
in wking/cincinnati-graph-data
Feb 6, 2020
792cc4c (Enable the 4.2.16 to 4.3.0 upgrade, 2020-02-03, #40) pulled the block to allow this edge, but to get an edge in a given channel, both the source and target release need to be in that channel. This was added to fast-4.3 in 792cc4c and later restricted to amd64 in 9a25271 (Do not add 4.2 s390 release to 4.3 channels, 2020-02-03, #41), but we'd skipped over candidate-4.3.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.