Skip to content

Enable 4.3.27 in stable channel(s) #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 2, 2020
Merged

Enable 4.3.27 in stable channel(s) #299

openshift-merge-robot merged 1 commit into from
Jul 2, 2020

Conversation

@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jun 24, 2020

Please merge within 48 hours of https://errata.devel.redhat.com/advisory/56099 shipping live OR a Cincinnati-first release.

This should provide adequate soak time for fast channel PR #298

This PR will also enable upgrades from 4.3.27 to releases in stable-4.4

@openshift-bot openshift-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 24, 2020
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 27, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 27, 2020

@openshift-bot: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Jun 30, 2020

Needs a rebase (looks like 4.3.26 went into stable-4.3.yaml via #292 since this PR was created).

@sdodson sdodson force-pushed the pr-stable-4.3.27 branch from 70de53e to b5565d8 Compare June 30, 2020 23:58
@sdodson
Copy link
Member

sdodson commented Jul 1, 2020

/refresh
/retest

@sdodson sdodson removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 1, 2020
@sdodson
Copy link
Member

sdodson commented Jul 2, 2020

/hold cancel
/assign @LalatenduMohanty
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2020
@sdodson
Copy link
Member

sdodson commented Jul 2, 2020

/uncc @jwforres @derekwaynecarr

LalatenduMohanty
LalatenduMohanty approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Jul 2, 2020

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit 15bbe5c into master Jul 2, 2020
@sdodson sdodson deleted the pr-stable-4.3.27 branch October 12, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LalatenduMohanty LalatenduMohanty

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-bot @openshift-ci-robot @wking @sdodson @LalatenduMohanty @openshift-merge-robot