Skip to content

Convert PromQL risks to Always risks in releases older than 8 weeks #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 2 commits into from
Jan 6, 2023
Merged

Convert PromQL risks to Always risks in releases older than 8 weeks #2968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
370f8a7
Convert PromQL risks to Always risks in releases older than 8 weeks
sdodson Jan 6, 2023
95c1702
Remove some old conditional updates which were added for demo purposes
sdodson Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 0 additions & 21 deletions blocked-edges/4.10.0-fc.2-modified-aws-load-balancer-service.yaml
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions blocked-edges/4.10.0-fc.4-alibaba-storage-fixes.yaml
View file
Open in desktop

This file was deleted.

9 changes: 1 addition & 8 deletions blocked-edges/4.10.10-parallel-ceph_fsync.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: CephParallelFsync
message: |-
This update would introduce a CephFS kernel driver regression, exposing a kernel panic when workloads make parallel ceph_fsync calls to the same file. The update also introduces many bug fixes as described in the errata, so weigh those against the risk of Ceph kernel panics when deciding whether to update or wait for an OpenShift release that also fixes the Ceph regression.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(ceph_health_status), "ceph", "yes", "", "")
or
label_replace(0 * group(cluster_version), "ceph", "no", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.11-parallel-ceph_fsync.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: CephParallelFsync
message: |-
This update would introduce a CephFS kernel driver regression, exposing a kernel panic when workloads make parallel ceph_fsync calls to the same file. The update also introduces many bug fixes as described in the errata, so weigh those against the risk of Ceph kernel panics when deciding whether to update or wait for an OpenShift release that also fixes the Ceph regression.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(ceph_health_status), "ceph", "yes", "", "")
or
label_replace(0 * group(cluster_version), "ceph", "no", "", "")
Copy link
Member

@wking wking Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly shift this PromQL into the message? Or the linked bug (although this one links https://bugzilla.redhat.com/show_bug.cgi?id=2076312#c9, which seems to be private)? But the current message is phrased as if we know (or suspect) the cluster is exposed, while with Always this will also trip for clusters we know are not exposed. Or 🤷, maybe that's more polish than we care about for such an old 4.10.z target as these.

Copy link
Member Author

@sdodson sdodson Jan 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to just leave it as is. Only 17% of the 4.10 fleet has upgrades to < 4.10.17 and those all have paths to better edges listed more prominently.

)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.12-parallel-ceph_fsync.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: CephParallelFsync
message: |-
This update would introduce a CephFS kernel driver regression, exposing a kernel panic when workloads make parallel ceph_fsync calls to the same file. The update also introduces many bug fixes as described in the errata, so weigh those against the risk of Ceph kernel panics when deciding whether to update or wait for an OpenShift release that also fixes the Ceph regression.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(ceph_health_status), "ceph", "yes", "", "")
or
label_replace(0 * group(cluster_version), "ceph", "no", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.13-parallel-ceph_fsync.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: CephParallelFsync
message: |-
This update would introduce a CephFS kernel driver regression, exposing a kernel panic when workloads make parallel ceph_fsync calls to the same file. The update also introduces many bug fixes as described in the errata, so weigh those against the risk of Ceph kernel panics when deciding whether to update or wait for an OpenShift release that also fixes the Ceph regression.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(ceph_health_status), "ceph", "yes", "", "")
or
label_replace(0 * group(cluster_version), "ceph", "no", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.14-parallel-ceph_fsync.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: CephParallelFsync
message: |-
This update would introduce a CephFS kernel driver regression, exposing a kernel panic when workloads make parallel ceph_fsync calls to the same file. The update also introduces many bug fixes as described in the errata, so weigh those against the risk of Ceph kernel panics when deciding whether to update or wait for an OpenShift release that also fixes the Ceph regression.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(ceph_health_status), "ceph", "yes", "", "")
or
label_replace(0 * group(cluster_version), "ceph", "no", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.14-release-data-with-hyphen-prefix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: ReleaseDataWithHyphenPrefix
message: |-
Clusters updating out of 4.10.14 may, depending on their past history, fail to initiate the update to any later release. In order to avoid this trouble, we recommend avoiding updates to this release. The linked solution includes steps to avoid the issue if you do decide to update to 4.10.14.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(cluster_version{type="initial",version=~"4[.][0-9][.].*"}),"born_by_4_9", "yes, so possibly touched a hyphen-hashing version", "", "")
or
label_replace(0 * group(cluster_version{type="initial",version!~"4[.][0-9][.].*"}),"born_by_4_9", "no, so will not have touched a hyphen-hashing version", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.15-parallel-ceph_fsync.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: CephParallelFsync
message: |-
This update would introduce a CephFS kernel driver regression, exposing a kernel panic when workloads make parallel ceph_fsync calls to the same file. The update also introduces many bug fixes as described in the errata, so weigh those against the risk of Ceph kernel panics when deciding whether to update or wait for an OpenShift release that also fixes the Ceph regression.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(ceph_health_status), "ceph", "yes", "", "")
or
label_replace(0 * group(cluster_version), "ceph", "no", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.15-release-data-with-hyphen-prefix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: ReleaseDataWithHyphenPrefix
message: |-
Clusters updating out of 4.10.15 may, depending on their past history, fail to initiate the update to any later release. In order to avoid this trouble, we recommend avoiding updates to this release. The linked solution includes steps to avoid the issue if you do decide to update to 4.10.15.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(cluster_version{type="initial",version=~"4[.][0-9][.].*"}),"born_by_4_9", "yes, so possibly touched a hyphen-hashing version", "", "")
or
label_replace(0 * group(cluster_version{type="initial",version!~"4[.][0-9][.].*"}),"born_by_4_9", "no, so will not have touched a hyphen-hashing version", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.16-parallel-ceph_fsync.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: CephParallelFsync
message: |-
This update would introduce a CephFS kernel driver regression, exposing a kernel panic when workloads make parallel ceph_fsync calls to the same file. The update also introduces many bug fixes as described in the errata, so weigh those against the risk of Ceph kernel panics when deciding whether to update or wait for an OpenShift release that also fixes the Ceph regression.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(ceph_health_status), "ceph", "yes", "", "")
or
label_replace(0 * group(cluster_version), "ceph", "no", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.16-release-data-with-hyphen-prefix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: ReleaseDataWithHyphenPrefix
message: |-
Clusters updating out of 4.10.16 may, depending on their past history, fail to initiate the update to any later release. In order to avoid this trouble, we recommend avoiding updates to this release. The linked solution includes steps to avoid the issue if you do decide to update to 4.10.16.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(cluster_version{type="initial",version=~"4[.][0-9][.].*"}),"born_by_4_9", "yes, so possibly touched a hyphen-hashing version", "", "")
or
label_replace(0 * group(cluster_version{type="initial",version!~"4[.][0-9][.].*"}),"born_by_4_9", "no, so will not have touched a hyphen-hashing version", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.17-release-data-with-hyphen-prefix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: ReleaseDataWithHyphenPrefix
message: |-
Clusters updating out of 4.10.17 may, depending on their past history, fail to initiate the update to any later release. In order to avoid this trouble, we recommend avoiding updates to this release. The linked solution includes steps to avoid the issue if you do decide to update to 4.10.17.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(cluster_version{type="initial",version=~"4[.][0-9][.].*"}),"born_by_4_9", "yes, so possibly touched a hyphen-hashing version", "", "")
or
label_replace(0 * group(cluster_version{type="initial",version!~"4[.][0-9][.].*"}),"born_by_4_9", "no, so will not have touched a hyphen-hashing version", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.18-release-data-with-hyphen-prefix.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: ReleaseDataWithHyphenPrefix
message: |-
Clusters updating out of 4.10.18 may, depending on their past history, fail to initiate the update to any later release. In order to avoid this trouble, we recommend avoiding updates to this release. The linked solution includes steps to avoid the issue if you do decide to update to 4.10.18.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(cluster_version{type="initial",version=~"4[.][0-9][.].*"}),"born_by_4_9", "yes, so possibly touched a hyphen-hashing version", "", "")
or
label_replace(0 * group(cluster_version{type="initial",version!~"4[.][0-9][.].*"}),"born_by_4_9", "no, so will not have touched a hyphen-hashing version", "", "")
)
- type: Always
7 changes: 1 addition & 6 deletions blocked-edges/4.10.38-node-creation-fails.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@ name: OpenStackNodeCreationFails
message: |-
Adding new nodes to the exsiting cluster on OpenStack will fail.
matchingRules:
- type: PromQL
promql:
promql: |
cluster_infrastructure_provider{type="OpenStack"}
or
0 * cluster_infrastructure_provider
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.4-parallel-ceph_fsync.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: CephParallelFsync
message: |-
This update would introduce a CephFS kernel driver regression, exposing a kernel panic when workloads make parallel ceph_fsync calls to the same file. The update also introduces many bug fixes as described in the errata, so weigh those against the risk of Ceph kernel panics when deciding whether to update or wait for an OpenShift release that also fixes the Ceph regression.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(ceph_health_status), "ceph", "yes", "", "")
or
label_replace(0 * group(cluster_version), "ceph", "no", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.5-parallel-ceph_fsync.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: CephParallelFsync
message: |-
This update would introduce a CephFS kernel driver regression, exposing a kernel panic when workloads make parallel ceph_fsync calls to the same file. The update also introduces many bug fixes as described in the errata, so weigh those against the risk of Ceph kernel panics when deciding whether to update or wait for an OpenShift release that also fixes the Ceph regression.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(ceph_health_status), "ceph", "yes", "", "")
or
label_replace(0 * group(cluster_version), "ceph", "no", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.6-parallel-ceph_fsync.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: CephParallelFsync
message: |-
This update would introduce a CephFS kernel driver regression, exposing a kernel panic when workloads make parallel ceph_fsync calls to the same file. The update also introduces many bug fixes as described in the errata, so weigh those against the risk of Ceph kernel panics when deciding whether to update or wait for an OpenShift release that also fixes the Ceph regression.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(ceph_health_status), "ceph", "yes", "", "")
or
label_replace(0 * group(cluster_version), "ceph", "no", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.7-parallel-ceph_fsync.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: CephParallelFsync
message: |-
This update would introduce a CephFS kernel driver regression, exposing a kernel panic when workloads make parallel ceph_fsync calls to the same file. The update also introduces many bug fixes as described in the errata, so weigh those against the risk of Ceph kernel panics when deciding whether to update or wait for an OpenShift release that also fixes the Ceph regression.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(ceph_health_status), "ceph", "yes", "", "")
or
label_replace(0 * group(cluster_version), "ceph", "no", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.8-parallel-ceph_fsync.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: CephParallelFsync
message: |-
This update would introduce a CephFS kernel driver regression, exposing a kernel panic when workloads make parallel ceph_fsync calls to the same file. The update also introduces many bug fixes as described in the errata, so weigh those against the risk of Ceph kernel panics when deciding whether to update or wait for an OpenShift release that also fixes the Ceph regression.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(ceph_health_status), "ceph", "yes", "", "")
or
label_replace(0 * group(cluster_version), "ceph", "no", "", "")
)
- type: Always
9 changes: 1 addition & 8 deletions blocked-edges/4.10.9-parallel-ceph_fsync.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,4 @@ name: CephParallelFsync
message: |-
This update would introduce a CephFS kernel driver regression, exposing a kernel panic when workloads make parallel ceph_fsync calls to the same file. The update also introduces many bug fixes as described in the errata, so weigh those against the risk of Ceph kernel panics when deciding whether to update or wait for an OpenShift release that also fixes the Ceph regression.
matchingRules:
- type: PromQL
promql:
promql: |
topk(1,
label_replace(group(ceph_health_status), "ceph", "yes", "", "")
or
label_replace(0 * group(cluster_version), "ceph", "no", "", "")
)
- type: Always
7 changes: 1 addition & 6 deletions blocked-edges/4.11.0-fc.0-stale-insights-run-level-label.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@ name: StaleInsightsRunLevelLabel
message: |-
An 'openshift.io/run-level: 1' annotation on the openshift-insights namespace may cause "container has runAsNonRoot" for the insights operator when updating to 4.11.0-fc.0.
matchingRules:
- type: PromQL
promql:
promql: |
kube_namespace_labels{namespace="openshift-insights",label_openshift_io_run_level="1"}
or
0 * kube_namespace_labels{namespace="openshift-insights",label_openshift_io_run_level=""}
- type: Always
7 changes: 1 addition & 6 deletions blocked-edges/4.11.0-fc.0-stale-selinux-policies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@ name: StaleSELinuxPolicies
message: |-
Custom SELinux policies, such as those installed by OpenShift Virtualization, may result in kubelet issues when updating to 4.11.0-fc.0.
matchingRules:
- type: PromQL
promql:
promql: |
group(csv_succeeded{name=~"kubevirt-hyperconverged-operator[.].*"})
or
0 * group(csv_count)
- type: Always
7 changes: 1 addition & 6 deletions blocked-edges/4.11.0-fc.3-stale-insights-run-level-label.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@ name: StaleInsightsRunLevelLabel
message: |-
An 'openshift.io/run-level: 1' annotation on the openshift-insights namespace may cause "container has runAsNonRoot" for the insights operator when updating to 4.11.0-fc.3.
matchingRules:
- type: PromQL
promql:
promql: |
kube_namespace_labels{namespace="openshift-insights",label_openshift_io_run_level="1"}
or
0 * kube_namespace_labels{namespace="openshift-insights",label_openshift_io_run_level=""}
- type: Always
7 changes: 1 addition & 6 deletions blocked-edges/4.11.0-fc.3-stale-selinux-policies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@ name: StaleSELinuxPolicies
message: |-
Custom SELinux policies, such as those installed by OpenShift Virtualization, may result in kubelet issues when updating to 4.11.0-fc.3.
matchingRules:
- type: PromQL
promql:
promql: |
group(csv_succeeded{name=~"kubevirt-hyperconverged-operator[.].*"})
or
0 * group(csv_count)
- type: Always
7 changes: 1 addition & 6 deletions blocked-edges/4.11.0-rc.0-stale-insights-run-level-label.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@ name: StaleInsightsRunLevelLabel
message: |-
An 'openshift.io/run-level: 1' annotation on the openshift-insights namespace may cause "container has runAsNonRoot" for the insights operator when updating to 4.11.0-rc.0.
matchingRules:
- type: PromQL
promql:
promql: |
kube_namespace_labels{namespace="openshift-insights",label_openshift_io_run_level="1"}
or
0 * kube_namespace_labels{namespace="openshift-insights",label_openshift_io_run_level=""}
- type: Always
7 changes: 1 addition & 6 deletions blocked-edges/4.11.0-rc.0-stale-selinux-policies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@ name: StaleSELinuxPolicies
message: |-
Custom SELinux policies, such as those installed by OpenShift Virtualization, may result in kubelet issues when updating to 4.11.0-rc.0.
matchingRules:
- type: PromQL
promql:
promql: |
group(csv_succeeded{name=~"kubevirt-hyperconverged-operator[.].*"})
or
0 * group(csv_count)
- type: Always
7 changes: 1 addition & 6 deletions blocked-edges/4.11.0-rc.1-stale-insights-run-level-label.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@ name: StaleInsightsRunLevelLabel
message: |-
An 'openshift.io/run-level: 1' annotation on the openshift-insights namespace may cause "container has runAsNonRoot" for the insights operator when updating to 4.11.0-rc.1.
matchingRules:
- type: PromQL
promql:
promql: |
kube_namespace_labels{namespace="openshift-insights",label_openshift_io_run_level="1"}
or
0 * kube_namespace_labels{namespace="openshift-insights",label_openshift_io_run_level=""}
- type: Always
7 changes: 1 addition & 6 deletions blocked-edges/4.11.0-rc.1-stale-selinux-policies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@ name: StaleSELinuxPolicies
message: |-
Custom SELinux policies, such as those installed by OpenShift Virtualization, may result in kubelet issues when updating to 4.11.0-rc.1.
matchingRules:
- type: PromQL
promql:
promql: |
group(csv_succeeded{name=~"kubevirt-hyperconverged-operator[.].*"})
or
0 * group(csv_count)
- type: Always
7 changes: 1 addition & 6 deletions blocked-edges/4.11.0-rc.2-stale-insights-run-level-label.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@ name: StaleInsightsRunLevelLabel
message: |-
An 'openshift.io/run-level: 1' annotation on the openshift-insights namespace may cause "container has runAsNonRoot" for the insights operator when updating to 4.11.0-rc.2.
matchingRules:
- type: PromQL
promql:
promql: |
kube_namespace_labels{namespace="openshift-insights",label_openshift_io_run_level="1"}
or
0 * kube_namespace_labels{namespace="openshift-insights",label_openshift_io_run_level=""}
- type: Always
7 changes: 1 addition & 6 deletions blocked-edges/4.11.0-rc.2-stale-selinux-policies.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,4 @@ name: StaleSELinuxPolicies
message: |-
Custom SELinux policies, such as those installed by OpenShift Virtualization, may result in kubelet issues when updating to 4.11.0-rc.2.
matchingRules:
- type: PromQL
promql:
promql: |
group(csv_succeeded{name=~"kubevirt-hyperconverged-operator[.].*"})
or
0 * group(csv_count)
- type: Always
Loading