Skip to content

Enable 4.5.0-rc.1 in candidate channel(s) #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jun 6, 2020
Merged

Enable 4.5.0-rc.1 in candidate channel(s) #276

openshift-merge-robot merged 2 commits into from
Jun 6, 2020

Conversation

@openshift-bot
Copy link
Contributor

@openshift-bot openshift-bot commented Jun 5, 2020

Please merge immediately.

@wking
Copy link
Member

wking commented Jun 5, 2020

https://openshift-release.svc.ci.openshift.org/releasestream/4-stable/release/4.5.0-rc.1 is green enough for candidate.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 5, 2020
@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor Author

openshift-bot commented Jun 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Jun 6, 2020

publish:

File "/usr/lib64/python2.7/site-packages/yaml/parser.py", line 439, in parse_block_mapping_key
    "expected <block end>, but found %r" % token.id, token.start_mark)
yaml.parser.ParserError: while parsing a block mapping
  in "./channels/candidate-4.5.yaml", line 1, column 1
expected <block end>, but found '-'
  in "./channels/candidate-4.5.yaml", line 4, column 1

/hold

Needs a reroll to become valid YAML.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2020
AOS Automation Release Team and others added 2 commits June 6, 2020 10:04
@sdodson
Enable 4.5.0-rc.1 in candidate channel(s)
9569ad5
@sdodson
Add 4.4.6 to candidate-4.5 so there's an upgrade path from 4.4
18ea3b3 
This is of course the candidate channel and should in no way be seen as a
commitment that you will be able to upgrade from 4.4.6 to 4.5 at GA time.
Issues may be identified between now and GA that necessitate upgrades to
later 4.4.z before upgrading to 4.5.
@sdodson sdodson force-pushed the pr-candidate-4.5.0-rc.1 branch from 0d2e4a2 to 18ea3b3 Compare June 6, 2020 14:07
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2020
@sdodson
Copy link
Member

sdodson commented Jun 6, 2020

Fixed YAML, added 4.4.6 to provide upgrade paths.

@sdodson
Copy link
Member

sdodson commented Jun 6, 2020

/lgtm
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-bot, sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2fef120 into master Jun 6, 2020
@wking
Copy link
Member

wking commented Jun 6, 2020

I've filed #277 promoting 4.4.6 into fast-4.5 and stable-4.5, following up on this PR's promotion of 4.4.6 into candidate-4.5.

@sdodson sdodson deleted the pr-candidate-4.5.0-rc.1 branch October 12, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@sdodson sdodson

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-bot @wking @sdodson @openshift-ci-robot @openshift-merge-robot