Skip to content

Conversation

@openshift-bot
Copy link
Contributor

Please merge within 48 hours of https://errata.devel.redhat.com/advisory/54434 shipping live OR a Cincinnati-first release.

This should provide adequate soak time for fast channel PR #268

This PR will also enable upgrades from 4.2.34 to releases in stable-4.3

@openshift-bot openshift-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 27, 2020
@sdodson
Copy link
Member

sdodson commented Jun 5, 2020

/close
This release has been dropped.

@openshift-ci-robot
Copy link

@sdodson: Closed this PR.

Details

In response to this:

/close
This release has been dropped.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Jul 1, 2020

/reopen

@openshift-ci-robot
Copy link

@sdodson: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson
Copy link
Member

sdodson commented Jul 1, 2020

This was errantly closed, however since 4.2.36 is in process we'd prefer people upgrade to that version directly. Merge this once #305 merges in order to ensure fast-4.2 and stable-4.2 are in sync.

Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 2, 2020
@LalatenduMohanty
Copy link
Member

/hold till 4.2.36 get merged.

@LalatenduMohanty
Copy link
Member

@sdodson Can you please rebase this?

@LalatenduMohanty
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 2, 2020
@sdodson sdodson force-pushed the pr-stable-4.2.34 branch from 0b58a39 to 04fa85f Compare July 2, 2020 17:45
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020
@sdodson
Copy link
Member

sdodson commented Jul 2, 2020

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, openshift-bot, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,sdodson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2020
@openshift-bot
Copy link
Contributor Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit ee47e84 into master Jul 2, 2020
@sdodson sdodson deleted the pr-stable-4.2.34 branch October 12, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants