blocked-edges/4.11.6: Declare OVNNetworkPolicyLongName risk #2552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PratikMahajan
changed the title
A regression introduced in 4.11.6 may lead to OVN control plane failure and workload disruption.
PratikMahajan
force-pushed
the
block-4.11.6-ovn-long-ns
branch
from
24d422d to
c641333
Compare
openshift-ci
bot
added
the
approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PratikMahajan, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/cincinnati-graph-data
that referenced
this pull request
Sep 27, 2022
Fixing a typo from c641333 (blocked-edges/4.11.6: declare OVNNetworkPolicyLongName risk, 2022-09-27, openshift#2552). Otherwise the blocked-edges parsers thing this is informative docs, and not an actual risk declaration. With this change: $ hack/show-edges.py candidate-4.11 | grep ' 4[.]11[.]6$' 4.10.16 -(blocked: OVNNetworkPolicyLongName)-> 4.11.6 4.10.17 -(blocked: OVNNetworkPolicyLongName)-> 4.11.6 4.10.18 -(blocked: OVNNetworkPolicyLongName)-> 4.11.6 ...same OVNNetworkPolicyLongName for everything else going into 4.11.6... which is what we want.
wking
added a commit
to wking/cincinnati-graph-data
that referenced
this pull request
Jun 27, 2023
The PromQL approach is similar to what we used in c641333 (blocked-edges/4.11.6: declare OVNNetworkPolicyLongName risk, 2022-09-27, openshift#2552), except: * I'm using the PerformanceProfiles resource. * I'm using apiserver_storage_objects instead of cluster:usage:resources:sum, to cut out one lossy layer of indirection [1]. Generated by writing the 4.13.0 declaration by hand, and then copying out to other 4.13 releases with: $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.13' | jq -r '.nodes[].version' | grep '^4[.]13[.]' | grep -v '^4[.]13[.]0$' | while read V; do sed "s/4[.]13[.]0/${V}/g" blocked-edges/4.13.0-PerformanceProfilesCPUQuota.yaml > "blocked-edges/${V}-PerformanceProfilesCPUQuota.yaml"; done $ git add blocked-edges/4.13.*PerformanceProfilesCPUQuota.yaml [1]: https://github.com/openshift/cluster-monitoring-operator/blob/70dd5c9a414448ace1d07090730510d5922b6b18/jsonnet/rules.libsonnet#L291-L292C20
wking
added a commit
to wking/cincinnati-graph-data
that referenced
this pull request
Jun 27, 2023
The PromQL approach is similar to what we used in c641333 (blocked-edges/4.11.6: declare OVNNetworkPolicyLongName risk, 2022-09-27, openshift#2552), except: * I'm using the PerformanceProfiles resource. * I'm using apiserver_storage_objects instead of cluster:usage:resources:sum, to cut out one lossy layer of indirection [1]. Generated by writing the 4.13.0 declaration by hand, and then copying out to other 4.13 releases with: $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.13' | jq -r '.nodes[].version' | grep '^4[.]13[.]' | grep -v '^4[.]13[.]0$' | while read V; do sed "s/4[.]13[.]0/${V}/g" blocked-edges/4.13.0-PerformanceProfilesCPUQuota.yaml > "blocked-edges/${V}-PerformanceProfilesCPUQuota.yaml"; done $ git add blocked-edges/4.13.*PerformanceProfilesCPUQuota.yaml [1]: https://github.com/openshift/cluster-monitoring-operator/blob/70dd5c9a414448ace1d07090730510d5922b6b18/jsonnet/rules.libsonnet#L291-L292C20
wking
added a commit
to wking/cincinnati-graph-data
that referenced
this pull request
Jun 27, 2023
The PromQL approach is similar to what we used in c641333 (blocked-edges/4.11.6: declare OVNNetworkPolicyLongName risk, 2022-09-27, openshift#2552), except: * I'm using the PerformanceProfiles resource. * I'm using apiserver_storage_objects instead of cluster:usage:resources:sum, to cut out one lossy layer of indirection [1]. Generated by writing the 4.13.0 declaration by hand, and then copying out to other 4.13 releases with: $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.13' | jq -r '.nodes[].version' | grep '^4[.]13[.]' | grep -v '^4[.]13[.]0$' | while read V; do sed "s/4[.]13[.]0/${V}/g" blocked-edges/4.13.0-PerformanceProfilesCPUQuota.yaml > "blocked-edges/${V}-PerformanceProfilesCPUQuota.yaml"; done $ git add blocked-edges/4.13.*PerformanceProfilesCPUQuota.yaml [1]: https://github.com/openshift/cluster-monitoring-operator/blob/70dd5c9a414448ace1d07090730510d5922b6b18/jsonnet/rules.libsonnet#L291-L292C20
wking
added a commit
to wking/cincinnati-graph-data
that referenced
this pull request
Jun 28, 2023
The PromQL approach is similar to what we used in c641333 (blocked-edges/4.11.6: declare OVNNetworkPolicyLongName risk, 2022-09-27, openshift#2552), except: * I'm using the PerformanceProfiles resource. * I'm using apiserver_storage_objects instead of cluster:usage:resources:sum, to cut out one lossy layer of indirection [1]. Generated by writing the 4.13.0 declaration by hand, and then copying out to other 4.13 releases with: $ curl -s 'https://api.openshift.com/api/upgrades_info/graph?channel=candidate-4.13' | jq -r '.nodes[].version' | grep '^4[.]13[.]' | grep -v '^4[.]13[.]0$' | while read V; do sed "s/4[.]13[.]0/${V}/g" blocked-edges/4.13.0-PerformanceProfilesCPUQuota.yaml > "blocked-edges/${V}-PerformanceProfilesCPUQuota.yaml"; done $ git add blocked-edges/4.13.*PerformanceProfilesCPUQuota.yaml [1]: https://github.com/openshift/cluster-monitoring-operator/blob/70dd5c9a414448ace1d07090730510d5922b6b18/jsonnet/rules.libsonnet#L291-L292C20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression introduced in 4.11.6 may lead to OVN control plane failure and workload disruption.