Skip to content

Conversation

@openshift-bot
Copy link
Contributor

Please merge immediately. This PR does not need to wait for an advisory to ship, but the associated advisory is https://errata.devel.redhat.com/advisory/53642 .

This PR will also enable upgrades from 4.3.14 to releases in candidate-4.4

@LalatenduMohanty
Copy link
Member

/lgtm

@LalatenduMohanty
Copy link
Member

/lgtm cancel

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@sdodson sdodson force-pushed the pr-candidate-4.3.14 branch from a09caf1 to 5ff491a Compare April 22, 2020 12:46
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 22, 2020
@openshift-merge-robot openshift-merge-robot merged commit 4b7ac3e into master Apr 22, 2020
@@ -1,5 +1,6 @@
name: candidate-4.4
versions:
- 4.3.14+amd64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops ,not sorted

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had assumed this was a requirement of our new robot masters.

@wking wking deleted the pr-candidate-4.3.14 branch May 8, 2020 21:08
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Nov 12, 2020
Generated with:

  $ hack/backfill.py
  $ git checkout HEAD -- channels/candidate-4.3.yaml
  $ emacs channels/candidate-4.4.yaml

With the candidate-4.3 and 4.4 massaging so we don't get:

   - 4.3.14
  +- 4.3.14+amd64

and similar, where all arches went into candidate-4.3, but only amd64
went into the candidate-4.4, 5ff491a (Enable 4.3.14 in candidate
channel(s), 2020-04-22, openshift#193).
wking added a commit to wking/cincinnati-graph-data that referenced this pull request Nov 12, 2020
Generated with:

  $ hack/backfill.py
  $ git checkout HEAD -- channels/candidate-4.3.yaml
  $ emacs channels/candidate-4.4.yaml
  $ git checkout HEAD -- channels/stable-4.6.yaml

With the candidate-4.3 and 4.4 massaging so we don't get:

   - 4.3.14
  +- 4.3.14+amd64

and similar, where all arches went into candidate-4.3, but only amd64
went into the candidate-4.4, 5ff491a (Enable 4.3.14 in candidate
channel(s), 2020-04-22, openshift#193).

The stable-4.6 massaging is because we are delaying the 4.5->4.6
stable updates while we convince ourselves that fast traffic is
sufficiently reliable.
sdodson pushed a commit to sdodson/cincinnati-graph-data that referenced this pull request Dec 3, 2020
Generated with:

  $ hack/backfill.py
  $ git checkout HEAD -- channels/candidate-4.3.yaml
  $ emacs channels/candidate-4.4.yaml
  $ git checkout HEAD -- channels/stable-4.6.yaml

With the candidate-4.3 and 4.4 massaging so we don't get:

   - 4.3.14
  +- 4.3.14+amd64

and similar, where all arches went into candidate-4.3, but only amd64
went into the candidate-4.4, 5ff491a (Enable 4.3.14 in candidate
channel(s), 2020-04-22, openshift#193).

The stable-4.6 massaging is because we are delaying the 4.5->4.6
stable updates while we convince ourselves that fast traffic is
sufficiently reliable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants