Skip to content

Add 4.3.13 to candidate #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Apr 15, 2020
Merged

Add 4.3.13 to candidate #174

openshift-merge-robot merged 1 commit into from
Apr 15, 2020

Conversation

@thiagoalessio
Copy link
Member

@thiagoalessio thiagoalessio commented Apr 15, 2020

No description provided.

@wking wking mentioned this pull request Apr 15, 2020
Merged
@wking
Copy link
Member

wking commented Apr 15, 2020

CI is having throughput issues. For example, all four of the 4.3.9 jobs died on either AWS throttling or Boskos lease exhaustion (which is designed to protect us from excessive AWS throttling). We have had a few update-time failures, so far all on 4.3->4.3.13 GCP for ...unreachable during disruption...: 4.3.1, 4.3.5, and 4.3.10, but we don't block promotion on that. Will wait to see some success for 4.2 -> 4.3.13...

@wking
Copy link
Member

wking commented Apr 15, 2020

Success from 4.2. So I'm fine with this happening whenever ART is happy with the release state.

/hold

ART, pull the hold whenever you're ready.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@sosiouxme
Copy link
Member

sosiouxme commented Apr 15, 2020

/hold cancel
Release is accepted now and looks like @thiagoalessio did manually the parts that the release job failed on.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@wking
Copy link
Member

wking commented Apr 15, 2020

/lgtm

Looks like I forgot to approve earlier.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 15, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thiagoalessio, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 15, 2020
@wking
Copy link
Member

wking commented Apr 15, 2020

/hold

@wking wking added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@wking
Copy link
Member

wking commented Apr 15, 2020

/hold cancel

Never mind, just had a little freak-out about this not being in candidate-4.4, but it's there ;).

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2020
@openshift-merge-robot openshift-merge-robot merged commit 0946844 into openshift:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jottofar jottofar Awaiting requested review from jottofar

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thiagoalessio @wking @sosiouxme @openshift-ci-robot @openshift-merge-robot