blocked-edges/4.10.0-fc.2-modified-aws-load-balancer-service: Example conditional update #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
wking
force-pushed
the
example-conditional-block
branch
2 times, most recently
from
a796560 to
6b9ce65
Compare
… conditional update Since 39bc2fb (blocked-edges/4.7.4*: Targeted edge blocking and version 1.1.0, 2021-09-01, openshift#1056), we've had some example conditional updates back on * -> 4.7.4. But now that 4.10 has feature candidates, this commit adds a conditional edge based on a minor 4.10.0-fc.2 issue that was fixed in fc.3. Folks interested in seeing conditional edges in action can install fc.0 or fc.1 on AWS, and see that this conditional edge is not recommended. Or they can install fc.0 or fc.1 on a non-AWS platform to see that the conditional edge is recommended.
wking
force-pushed
the
example-conditional-block
branch
from
6b9ce65 to
38028a8
Compare
Contributor
|
@wking: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/cincinnati-graph-data
that referenced
this pull request
Feb 3, 2022
…update Following up on 38028a8 (blocked-edges/4.10.0-fc.2-modified-aws-load-balancer-service: Example conditional update, 2022-01-31, openshift#1437) with a new invented, demo conditional update. The earlier demo worked locally, but did not excercise Insights tooling, because Insights only bumped their openshift/api vendor in fc.3 [1]: $ for X in fc.0 fc.1 fc.2 fc.3 fc.4 rc.0; do echo -n "${X} "; oc adm release info --commits "quay.io/openshift-release-dev/ocp-release:4.10.0-${X}-x86_64" 2>/dev/null | grep insights-operator; done fc.0 insights-operator https://github.com/openshift/insights-operator cafe71a62bda6ca7ea790da90753b7b7d3c006b7 fc.1 insights-operator https://github.com/openshift/insights-operator e2887e735adefb572a2e785d5cc071ec5844b123 fc.2 insights-operator https://github.com/openshift/insights-operator 7a3ff6bbe5b59f9f49c3c6bb8c118e88618515fc fc.3 insights-operator https://github.com/openshift/insights-operator 007dfade2f36b95cedfd90a5a5ea6f0c5e89dab3 fc.4 insights-operator https://github.com/openshift/insights-operator 007dfade2f36b95cedfd90a5a5ea6f0c5e89dab3 rc.0 insights-operator https://github.com/openshift/insights-operator 007dfade2f36b95cedfd90a5a5ea6f0c5e89dab3 $ git --no-pager log --oneline --first-parent cafe71a62bd^..origin/release-4.10 007dfade (HEAD -> bump-openshift-api, origin/release-4.11, origin/release-4.10, origin/master, origin/HEAD, master) Minor gathering docs update (openshift#575) b67157fc Remove "InsightsOperatorPullingSCA" TP feature check (openshift#574) 5c541f9a info alert when the SCA is not available (openshift#565) 508a6642 Bump k8s & OpenShift versions (openshift#572) d22988ee feat: conditional log gathers into a single gather and PrometheusOperatorSyncFailed (openshift#563) 7a3ff6bb Remove unnecessary division into important and failable gatherers (openshift#567) e2887e73 Updating ose-insights-operator images to be consistent with ART (openshift#540) cafe71a6 Update versions for backports in our gathered data docs (openshift#566) So fc.0 and fc.1 with the previous conditional update were having that unrecognized-to-the-older-insights-operator property dropped. This commit adds a new demo conditional edge for 4.10 -> fc.4, so we can look at running fc.3 clusters to see conditionalUpdates in Insights. [1]: openshift/insights-operator@03a335c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 39bc2fb (#1056), we've had some example conditional updates back on
* -> 4.7.4. But now that 4.10 has feature candidates, this commit adds a conditional edge based on a minor 4.10.0-fc.2 issue that was fixed in fc.3. Folks interested in seeing conditional edges in action can install fc.0 or fc.1 on AWS, and see that this conditional edge is not recommended. Or they can install fc.0 or fc.1 on a non-AWS platform to see that the conditional edge is recommended.