Skip to content

Conversation

@thiagoalessio
Copy link
Member

No description provided.

@sdodson
Copy link
Member

sdodson commented Mar 26, 2020

/hold
For errata publishing.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2020
@wking
Copy link
Member

wking commented Mar 26, 2020

Also blocked on #142.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 26, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2020
@LalatenduMohanty
Copy link
Member

LalatenduMohanty commented Apr 3, 2020

/lgtm

As we have already blocked edge https://github.com/openshift/cincinnati-graph-data/blob/master/blocked-edges/4.3.9.yaml. Telemetry looks fine.

@wking
Copy link
Member

wking commented Apr 3, 2020

/hold cancel

#142 has landed; 24 hours cook time elapsed.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2020
@wking
Copy link
Member

wking commented Apr 3, 2020

/lgtm

For some reason, @LalatenduMohanty 's didn't stick.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2020
@eparis
Copy link
Member

eparis commented Apr 7, 2020

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eparis, LalatenduMohanty, thiagoalessio, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2020
@openshift-merge-robot openshift-merge-robot merged commit 3004e58 into openshift:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants