hack/stabilization-changes: Allow local changes without branching #1039
+27
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have a GitHub token, we checkout a branch and create a pull request for each promotion. When we don't have a token, we used to just log the changes that needed to happen. With this commit, a token-less call will now edit the local files to perform all appropriate promotions. That allows this script (which understands about tombstones and filters and other promotion criteria) to be used to backfill channels when we expand filters (e.g. allowing 4.(y-1) in fast-4.y after 4.y GAs, or allowing 4.(y-1) in stable-4.y after we feel comfortable with the fast behavior. That should make things like 8da5782 (4.8 GA -- Fill in 4.7.z into fast-4.8, 2021-07-26, openshift#947)'s accidental promotion of the tombstoned 4.7.10 and similar less likely. More on that in 4c53c7b (Blocking all the incoming edges to 4.7.10, 4.7.14, 4.7.15, 4.7.20, 2021-09-03, openshift#1035). Drop the old backfill script from 2a02325 (hack/backfill: Add a backfilling script, 2020-11-12, openshift#549), now that this new functionality makes it obsolete.
openshift-ci
bot
added
the
approved
wking
added a commit
to wking/cincinnati-graph-data
that referenced
this pull request
Sep 20, 2021
Generated with: $ sed -i '/^ filter: /d' channels/stable-4.8.yaml $ hack/stabilization-changes.py but using the still-in-flight version of that script from [1] to include the promotions in this commit, so the stabilization bot doesn't follow up with a whole bunch of parallel promotion pull requests. We've been cooking in fast-4.8 long enough that we feel fairly confident that major 4.7 -> 4.8 issues will have surfaced by now. [1]: openshift#1039
Member
|
/test validate-blocked-edges |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a GitHub token, we checkout a branch and create a pull request for each promotion. When we don't have a token, we used to just log the changes that needed to happen. With this commit, a token-less call will now edit the local files to perform all appropriate promotions. That allows this script (which understands about tombstones and filters and other promotion criteria) to be used to backfill channels when we expand filters (e.g. allowing 4.(y-1) in fast-4.y after 4.y GAs, or allowing 4.(y-1) in stable-4.y after we feel comfortable with the fast behavior. That should make things like 8da5782 (#947)'s accidental promotion of the tombstoned 4.7.10 and similar less likely. More on that in 4c53c7b (#1035).
Drop the old backfill script from 2a02325 (#549), now that this new functionality makes it obsolete.