blocked-edges/4.7.28: Expand blocked release to include fast-4.8 zombies #1038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few releases slipped into fast-4.8, despite being tombzoned in candidate releases, 4c53c7b (Blocking all the incoming edges to 4.7.10, 4.7.14, 4.7.15, 4.7.20, 2021-09-03, openshift#1035). Because I'd been comparing with fast-4.7 when developing the 4.7.28 blocker regexp, 2a70cf5 (blocked-edges: Block some edges into 4.7.24, 4.7.28, 4.8.5, and 4.8.9 on CRI-O /run leak, 2021-08-31, openshift#1022), those zombie releases still had edges: $ join <(oc adm release info -o json quay.io/openshift-release-dev/ocp-release:4.7.28-x86_64 | jq -r '.metadata.previous[] | select(test("^(4[.]6[.].*|4[.]7[.][0-9]|4[.]7[.]1[1236789]|4[.]7[.]2[123])$") | not)' | sort) <(curl -s 'https://api.openshift.com/api/upgrades_info/v1/graph?channel=fast-4.8&arch=amd64' | jq -r '.nodes[].version' | sort) 4.7.10 4.7.14 4.7.15 4.7.20 4.7.24 With this commit, I'm extending the regular expression to exclude them, except for 4.7.24 which is already vulnerable to the bugs impacting 4.7.28: $ join <(oc adm release info -o json quay.io/openshift-release-dev/ocp-release:4.7.28-x86_64 | jq -r '.metadata.previous[] | select(test("^(4[.]6[.].*|4[.]7[.][0-9]|4[.]7[.]1[0-9]|4[.]7[.]2[0123])$") | not)' | sort) <(curl -s 'https://api.openshift.com/api/upgrades_info/v1/graph?channel=fast-4.8&arch=amd64' | jq -r '.nodes[].version' | sort) 4.7.24
openshift-ci
bot
added
the
approved
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/cincinnati-graph-data
that referenced
this pull request
Sep 8, 2021
Like 9ba34fc (blocked-edges/4.7.28: Expand blocked release to include fast-4.8 zombies, 2021-09-03, openshift#1038), but for 4.7.29.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few releases slipped into fast-4.8, despite being tombzoned in candidate releases, 4c53c7b (#1035). Because I'd been comparing with fast-4.7 when developing the 4.7.28 blocker regexp, 2a70cf5 (#1022), those zombie releases still had edges:
With this commit, I'm extending the regular expression to exclude them, except for 4.7.24 which is already vulnerable to the bugs impacting 4.7.28: