create namespace for leader election to succeed for resource watcher in upgrade #974
Conversation
pkg/steps/clusterinstall/template.go
Outdated
| REPOSITORY_PATH=/resourcewatch openshift-tests run-resourcewatch --kubeconfig=${KUBECONFIG} --namespace=ci-operator-monitor & | ||
| rw_pid=$! | ||
| openshift-tests run-resourcewatch --help > /dev/null 2>&1 | ||
| rwsupported=$? |
There was a problem hiding this comment.
I think these two lines need to be changed. Could you replace the 325-326 with these two lines?
rwsupported=0
openshift-tests run-resourcewatch --help > /dev/null 2>&1 || rwsupported=$?
There was a problem hiding this comment.
well, this is a pretty bad look. We're hosed again.
I'll try one last tiem to fix it
There was a problem hiding this comment.
We use 'set -e' that is really the trouble maker. I don't like set -e at all. Since it fails with any error, we have to invent these kind of workaround that makes the scripts look very ugly.
I have written lengthy shell scripts and maintained them, while taking care of my own error handling. Never had a problem with scripts or error handling.
|
if this doesn't work, I'm revert the whole lot to prepare for the next disruptive bit. We have got to find a better way, this is garbage. |
deads2k
added
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
5 participants
builds on #973
/assign @damemi