ci-operator multi-stage: add step parameters #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
bbguimaraes
force-pushed
the
multi_stage_env
branch
from
2754ded to
6f4ff70
Compare
Contributor
Author
Implementation of the execution side of the proposal described in: https://docs.google.com/document/d/14CLXQ4NgHNZHw_FGfmNsqxC1FGgK5qVb6uRc9XIafws
bbguimaraes
force-pushed
the
multi_stage_env
branch
from
6f4ff70 to
c0b3e02
Compare
petr-muller
reviewed
Jun 3, 2020
petr-muller
approved these changes
Jun 3, 2020
Member
petr-muller
left a comment
petr-muller
left a comment
There was a problem hiding this comment.
/hold
LGTM, holding for others (I think it would be good if this got more reviews, it's a significant, user-facing feature and it's worth the time to get it right)
openshift-ci-robot
added
the
do-not-merge/hold
Contributor
stevekuznetsov
left a comment
stevekuznetsov
left a comment
There was a problem hiding this comment.
Where is the documentation for this in our help page?
bbguimaraes
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
Author
Contributor
Author
|
Huh… /retest |
Contributor
Author
|
Cache… Haven't seen that error anywhere else. /retest |
Contributor
|
/lgtrm |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bbguimaraes, petr-muller, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Jun 16, 2020
…ST_SUITE Taking advantage of openhsift/ci-tools@62e7498d66 (ci-operator multi-stage: add step parameters, 2020-05-27, openshift/ci-tools#854). This commit doesn't override the defaults yet, but a useful override would be: TEST_COMMAND=run-upgrade TEST_SUITE=all This replaces test-suite.txt, which landed in a2fd8c3 (step-registry: add Origin E2E test step, 2020-01-31, openshift#6965), and also had no consumers.
This was referenced Jun 16, 2020
ci-operator/step-registry/openshift/e2e/test: Add TEST_COMMAND and TEST_SUITE
openshift/release#9676
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the proposal described in:
https://docs.google.com/document/d/14CLXQ4NgHNZHw_FGfmNsqxC1FGgK5qVb6uRc9XIafws
TODO: