pj-rehearse: Disable rehearsals on tests where the 'restrict_network_access' config is toggled to 'false' - #4348
Conversation
…g has been set to 'false' on the candidate ref. This is done to disallow rehearsing any test that bypasses the firewall without first having someone reviewed the configuration.
openshift-ci
Bot
added
the
approved
|
/hold so I can monitor the rollout |
openshift-ci
Bot
added
the
do-not-merge/hold
|
/label tide/merge-method-squash |
openshift-ci
Bot
added
the
tide/merge-method-squash
|
/test remaining-required |
|
/retest-required |
|
@smg247: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bear-redhat, smg247 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
3 participants
This is done to disallow rehearsing any test that bypasses the firewall without first having someone reviewed the configuration.
Iff we find other cases where specific fields being changed should disable the entire rehearsal, we could make this logic more general. For now, this is sufficient.
For: https://issues.redhat.com/browse/DPTP-4171