pj-rehearse: implement rehearsing of changed registry steps #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
petr-muller
reviewed
Dec 10, 2019
Member
petr-muller
left a comment
petr-muller
left a comment
There was a problem hiding this comment.
I mostly skimmed the code, looks mostly fine to me (few comments inline). Needs tests.
AlexNPavel
force-pushed
the
rehearse-steps
branch
2 times, most recently
from
7569742 to
5449484
Compare
AlexNPavel
force-pushed
the
rehearse-steps
branch
from
5449484 to
8f54239
Compare
Contributor
stevekuznetsov
left a comment
stevekuznetsov
left a comment
There was a problem hiding this comment.
Implementation looks good
openshift-ci-robot
added
size/XXL
AlexNPavel
force-pushed
the
rehearse-steps
branch
from
13a2f64 to
12ca89f
Compare
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
stevekuznetsov
approved these changes
Dec 10, 2019
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexNPavel, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for choosing presubmits to rehearse based on changed registry steps.