Skip to content

Check if AWS_SHARED_CREDENTIALS_FILE is set #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 3 commits into from
Jul 24, 2019
Merged

Check if AWS_SHARED_CREDENTIALS_FILE is set #30

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93f9880
Check if AWS_SHARED_CREDENTIALS_FILE is set
hongkailiu Jul 23, 2019
706c647
Add comments on ipi-deprovision.sh
hongkailiu Jul 23, 2019
9dbcc5e
Take params of ipi-deprovision.sh from env. var.
hongkailiu Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/ipi-deprovision/ipi-deprovision.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
#!/bin/sh

@stevekuznetsov stevekuznetsov Jul 24, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I don't think we want to run POSIX shell. If we have bash, let's use it.

@hongkailiu hongkailiu Jul 24, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. CP/Paste error.


if [ -z "${AWS_SHARED_CREDENTIALS_FILE}" ]; then echo "ENV VAR AWS_SHARED_CREDENTIALS_FILE is not set"; exit 1; fi

@stevekuznetsov stevekuznetsov Jul 24, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: prefer

if [[ -z "${AWS_SHARED_CREDENTIALS_FILE:-}" ]]; then
    echo "Required variable \$AWS_SHARED_CREDENTIALS_FILE unset"
    exit 1
fi

@stevekuznetsov stevekuznetsov Jul 24, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can't we just omit this? The AWS library will fail when no credentials are found, and this script could be used locally with the credentials in $HOME

@hongkailiu hongkailiu Jul 24, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted.


### expirationDate is always with timezone +00:00, eg, "2019-07-23T22:35+0000"

@stevekuznetsov stevekuznetsov Jul 24, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is out of place

@hongkailiu hongkailiu Jul 24, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved a bit.

MY_DATE=$(TZ=":Africa/Abidjan" date '+%Y-%m-%d')
declare -a regions=("us-east-1" "us-east-2" "us-west-1")
Expand Down