prowgen: support overriding prowjob timeout #2294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrutkovs
force-pushed
the
override-job-timeout
branch
from
3e1ce7e to
849b869
Compare
Member
|
Can you use |
Contributor
Author
In the end the timeout needs to be set, yes, but either:
Not sure which option is preferable, this PR implements option 1 |
Member
|
I think this is fine if it has some sane enforced upper limit ('d be conservative and went for 8h). |
openshift-ci
bot
added
needs-rebase
openshift-ci
bot
added
the
needs-rebase
vrutkovs
force-pushed
the
override-job-timeout
branch
from
849b869 to
3bd7692
Compare
openshift-ci
bot
removed
the
needs-rebase
vrutkovs
force-pushed
the
override-job-timeout
branch
from
3bd7692 to
69ea12b
Compare
Contributor
Author
|
Limited job time to 8hrs |
2 tasks
petr-muller
reviewed
Sep 7, 2021
Member
petr-muller
left a comment
petr-muller
left a comment
There was a problem hiding this comment.
I think we'll also need a small doc followup for https://docs.ci.openshift.org/docs/architecture/timeouts/ (does not block merge)
| maxCustomDuration := time.Hour * 8 | ||
| if timeout != nil && timeout.Duration <= maxCustomDuration { | ||
| decorationConfig.Timeout = timeout | ||
| } |
Member
There was a problem hiding this comment.
I think we should actively refuse this in ci-op config validation (https://github.com/openshift/ci-tools/blob/master/pkg/validation/test.go#L116) with some sensible error message instead of capping it silently.
Contributor
Author
There was a problem hiding this comment.
good idea, implemented
Add "Timeout" param to the test, which would reset `decoration_config.timeout` so that some tests could run longer than 4 hours
vrutkovs
force-pushed
the
override-job-timeout
branch
from
69ea12b to
e2369d4
Compare
petr-muller
approved these changes
Sep 9, 2021
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
wking
added a commit
to wking/ci-docs
that referenced
this pull request
Nov 3, 2021
Catching up with [1]. [1]: openshift/ci-tools#2294
Member
|
I've filed openshift/ci-docs#196 to doc this new setting. |
wking
added a commit
to wking/openshift-release
that referenced
this pull request
Nov 18, 2021
The 4.9 to 4.10 to 4.9 rollbacks keep hitting the 3h timeout: $ w3m -dump -cols 200 'https://search.ci.openshift.org/?maxAge=96h&type=junit&name=4.10-upgrade-from-stable-4.9&search=Process+did+not+finish+before.*timeout' | grep 'rollback.*failures match' periodic-ci-openshift-release-master-ci-4.10-upgrade-from-stable-4.9-e2e-aws-ovn-upgrade-rollback (all) - 4 runs, 100% failed, 75% of failures match = 75% impact periodic-ci-openshift-release-master-ci-4.10-upgrade-from-stable-4.9-e2e-aws-upgrade-rollback (all) - 2 runs, 100% failed, 50% of failures match = 50% impact $ w3m -dump -cols 200 'https://search.ci.openshift.org/search?maxAge=96h&type=junit&context=0&name=4.10-upgrade-from-stable-4.9&search=Process+did+not+finish+before.*timeout' | jq -r 'to_entries[].value | to_entries[].value[] | .name + " " + .context[0]' | sed -n 's/\(.*rollback\) .*before \([^ ]*\) timeout.*/\1 \2/p' periodic-ci-openshift-release-master-ci-4.10-upgrade-from-stable-4.9-e2e-aws-ovn-upgrade-rollback 3h0m0s periodic-ci-openshift-release-master-ci-4.10-upgrade-from-stable-4.9-e2e-aws-ovn-upgrade-rollback 3h0m0s periodic-ci-openshift-release-master-ci-4.10-upgrade-from-stable-4.9-e2e-aws-ovn-upgrade-rollback 3h0m0s periodic-ci-openshift-release-master-ci-4.10-upgrade-from-stable-4.9-e2e-aws-upgrade-rollback 3h0m0s We've had the 3h timeout since 90fadfe (steps/openshift-e2e-test: e2e tests can take longer than 2h, 2021-01-06, openshift#14674). We still need some time for setup and teardown in the wrapping Prow job [1], so I'm also setting timeout on the jobs, via [2]. That leaves us exposed to situations where other jobs that use this same step hang up and spend so long in the step, that a wrapping Plank/Prow timeout leaves them with too little time to finish their teardown/gather. But if that happens, maybe the test-platform folks will give us either a way to override a single step's timeout for a job, or a blanket increase in the Plank/Prow cap. [1]: https://docs.ci.openshift.org/docs/architecture/timeouts/ [2]: openshift/ci-tools#2294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "Timeout" param to the test, which would reset
decoration_config.timeoutso that some tests could run longer than 4 hours.Example job: openshift/release#21355
TODO:
24hwould be sufficient for now?Ref: https://issues.redhat.com/browse/DPTP-889