steps/clusterinstall: Upgrade template is out of date #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update it to the latest state which contains important fixes for some upgrade environments and gather data on teardown.
openshift-ci-robot
added
the
approved
petr-muller
approved these changes
Feb 4, 2021
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
reviewed
Feb 4, 2021
| # TODO: make openshift-tests auto-discover this from cluster config | ||
| REGION="$(oc get -o jsonpath='{.status.platformStatus.gcp.region}' infrastructure cluster)" | ||
| export TEST_PROVIDER="{\"type\":\"gce\",\"region\":\"${REGION}\",\"multizone\": true,\"multimaster\":true,\"projectid\":\"openshift-gce-devel-ci\"}" | ||
| export TEST_PROVIDER='{"type":"gce","region":"us-east1","multizone": true,"multimaster":true,"projectid":"openshift-gce-devel-ci"}' |
Member
There was a problem hiding this comment.
this is backsliding vs #1527 , because I haven't been able to convince anyone to review openshift/release#14324, and haven't bothered pushing the change to other sections of openshift/release with that PR still in flight.
wking
reviewed
Feb 4, 2021
| AWS_REGION="${LEASED_RESOURCE}" | ||
| case "${AWS_REGION}" in | ||
| us-east-1) | ||
| case $((RANDOM % 4)) in |
wking
reviewed
Feb 4, 2021
| elif [[ "${CLUSTER_TYPE}" == "azure4" ]]; then | ||
| AZURE_REGION="${LEASED_RESOURCE}" | ||
| case $((RANDOM % 8)) in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update it to the latest state which contains important fixes for
some upgrade environments and gather data on teardown.