pj-rehearse: no longer detect references to ci-op config CMs #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, pj-rehearse had code that detected when Prow jobs mounted ci-operator config CMs (`ci-operator-*-configs`) directly, and handled resolving and inlining this case. OpenShift CI Prowjobs are no longer supposed to mount ci-op configs like this (and no longer do so [1]), so all this code is no longer necessary. [1] ```console $ git grep 'ci-operator-.*-configs' ci-operator/jobs/ $ ```
openshift-ci-robot
added
the
approved
Member
Author
|
/test e2e |
petr-muller
force-pushed
the
unresolved-config-prep
branch
from
327b494 to
44377ec
Compare
alvaroaleman
approved these changes
Nov 19, 2020
Contributor
alvaroaleman
left a comment
alvaroaleman
left a comment
There was a problem hiding this comment.
Code removal, I like
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, petr-muller The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, pj-rehearse had code that detected when Prow jobs mounted
ci-operator config CMs (
ci-operator-*-configs) directly, and handledresolving and inlining this case. OpenShift CI Prowjobs are no longer
supposed to mount ci-op configs like this (and no longer do so [1]), so
all this code is no longer necessary.
[1]
$ git grep 'ci-operator-.*-configs' ci-operator/jobs/ $This code cleanup is part of DPTP-1685