Skip to content

pkg/steps/template: Push "Executing pod..." logging into createOrRestartPod #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Oct 8, 2020
Merged

pkg/steps/template: Push "Executing pod..." logging into createOrRestartPod #1284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/steps/multi_stage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,6 @@ func (s *multiStageTestStep) runPods(ctx context.Context, pods []coreapi.Pod, sh
namePrefix := s.name + "-"
var errs []error
for _, pod := range pods {
log.Printf("Executing %q", pod.Name)
var notifier ContainerNotifier = NopNotifier
for _, c := range pod.Spec.Containers {
if c.Name == "artifacts" {
Expand Down
1 change: 1 addition & 0 deletions pkg/steps/template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,7 @@ func createOrRestartPod(podClient coreclientset.PodInterface, pod *coreapi.Pod)
return nil, fmt.Errorf("unable to delete completed pod: %w", err)
}
var created *coreapi.Pod
log.Printf("Executing pod %q", pod.Name)
// creating a pod in close proximity to namespace creation can result in forbidden errors due to
// initializing secrets or policy - use a short backoff to mitigate flakes
if err := wait.ExponentialBackoff(wait.Backoff{Steps: 4, Factor: 2, Duration: time.Second}, func() (bool, error) {
Expand Down