Registry replacer: Update dockerfiles from ocp-build-data #1093
Conversation
openshift-ci-robot
added
the
approved
|
/assign @jupierce @stevekuznetsov |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
|
/retest |
alvaroaleman
force-pushed
the
dockerfile-ocp-build-data
branch
from
4607c07 to
cfbb475
Compare
| ignoredRepos sets.String, | ||
| ) { | ||
|
|
||
| // The tool only works for the current release |
There was a problem hiding this comment.
Technically we just need it to not be a branch that's being fast forwarded to right? So like release-4.2 would be fine
There was a problem hiding this comment.
Right. Currently the assumption is that we will only use this going forward. We should probably make this configurable but we won't need it for older releases.
alvaroaleman
force-pushed
the
dockerfile-ocp-build-data
branch
from
a2cd2e3 to
9f1b048
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, jupierce, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
5 participants
The diff this PR produces is here: openshift/release#10799
First commit is pure moving code around, second commit is the actual change.