This repository was archived by the owner on Jun 14, 2019. It is now read-only.
Remove support for release configurations not in a single stream #283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
Contributor
stevekuznetsov
left a comment
stevekuznetsov
left a comment
There was a problem hiding this comment.
Would want to see you remove the field from the config (and from all other parts in the config where we do this nonsense but nobody uses it)
Contributor
Author
|
Remove |
We don't use this code and are unlikely to at any point in the future. Clean up these code paths prior to supporting upgrade logic.
smarterclayton
force-pushed
the
publish_initial
branch
from
718b942 to
50b32dd
Compare
Contributor
Author
|
I verified no one is using the tag form, removed from API, updated docs, code, and tests. |
openshift-ci-robot
added
size/L
Contributor
Author
|
PTAL |
Contributor
stevekuznetsov
left a comment
stevekuznetsov
left a comment
There was a problem hiding this comment.
I think this seems reasonable
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use this code and are unlikely to at any point in the future.
Clean up these code paths prior to supporting upgrade logic.
Builds on #282, only the latest commit is new