output logs containerwise.

[droslean]

Adds the ci-operator.openshift.io/always-show-container-output annotation to specify which container logs, will be shown after the pod will fail.

closes #185

[droslean]

/assign @bbguimaraes @petr-muller @stevekuznetsov

[petr-muller]

I am confused about the intention of this change. I expected to find a different feature here! :)

My understanding is the following:

1. In Add annotation to output logs for all containers. #184, we added a feature where, providing a boolean annotation, the users can force output from all containers to be present, no matter the exit code.
2. @bbguimaraes requested changes in the feature and you filed Annotation to force log output containerwise. #185 for it
3. This PR is supposed to close Annotation to force log output containerwise. #185 but to me, it looks this is a different feature.

Can you clarify? How is this related to #185? If it's unrelated, what is this feature (a different issue?).

[droslean]

@bbguimaraes requested the changes, but in the end, it turned out that we will need the feature described in #184. This PR adds a new feature, described in #185.

[petr-muller]

I'm wondering if always-show-container-output is the right name for the annotation (the name was reused from the previous feature, right?). It may be misleading because it looks similar to the always-show-output one but works differently. I don't like the always part - it's not true (always != when pod fails and only if container terminated) and it is what makes it similar to always-show-output.

I am not sure about a good name, though... containers-logged-on-failure ?

[petr-muller]

Briefly describe the default state somewhere. What containers' output is captured by default?

[petr-muller]

Perhaps include this into the descriptions themselves? This would require rewritting all of them into a different form, but I think it would be worth the improvement.

Comma-separated list of container names for which ci-operator will wait until complete / for which ci-operator will collect and log their output if pod fails

[petr-muller]

I don't think the annotation name well represents the feature - we'll need to come up with something better.

Other comments are suggestions.

[petr-muller]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [droslean,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment