Skip to content
This repository was archived by the owner on Jun 14, 2019. It is now read-only.

Conversation

@vrutkovs
Copy link
Contributor

Set RPM_REPO_CRIO_DIR based on current release. crio RPMs are stored in different path dirs for 4.0 and 4.1 thus a simple map is required to pick the right one

Required for openshift/release#3761

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 13, 2019
@petr-muller
Copy link
Member

/test breaking-changes

(apologies for the noise, just merged a Sentry-reporting feature, need a Prow job failure to check everything works)

@vrutkovs vrutkovs force-pushed the rpm_repo_crio_dir branch from b55903a to 0666fc5 Compare May 20, 2019 09:01
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 20, 2019
@openshift-ci-robot
Copy link

@vrutkovs: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/breaking-changes 0666fc5 link /test breaking-changes

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 24, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit 6c371e4 into openshift:master May 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants