add gcp cluster type for selection

[droslean]

No description provided.

[droslean]

/cc @petr-muller @bbguimaraes @stevekuznetsov

[petr-muller]

why not I guess :D
/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [droslean,petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[droslean]

why not I guess :D

@petr-muller related PR that the template was changed but we didn't trigger the rehearse:
openshift/release#3691

I triggered it manually. ci/rehearse/openshift/jenkins/openshift-3.11/e2e-gcp

[stevekuznetsov]

Don't we have constants for these somewhere? Ew. We need to re-think what is going on with these constants. Is it better when we move all templates to Go code?

[bbguimaraes]

I mentioned it in the original review: we didn't have these constants in ci-operator-prowgen to avoid this. The ones we use to generate jobs are in ci-operator, but even there we don't have a hard-coded list that has to be manually updated.

At this point in the execution in rehearse, we have all jobs from the master and candidate branches loaded in memory, why not derive the list from them?