This repository was archived by the owner on Jun 14, 2019. It is now read-only.
Rehearsal metrics: Find and count stale rehearsal occurences #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stale rehearsals happen when the rehearsal tool selects different jobs to rehearse for a single commit (so a /retest needs to be involved). These rehearsals are confusing when they fail, because they are very hard to get rid of (they cannot be separately rerun, and pj-rehearse does not attempt to re-run them either). This change makes the metrics tool track occurrences of this. Related to: - DPTP-368 - openshift#131
openshift-ci-robot
requested review from
bbguimaraes,
droslean and
stevekuznetsov
openshift-ci-robot
added
size/L
Contributor
|
/lgtm Nice! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: petr-muller, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stale rehearsals happen when the rehearsal tool selects different jobs
to rehearse for a single commit (so a /retest needs to be involved).
These rehearsals are confusing when they fail, because they are very
hard to get rid of (they cannot be separately rerun, and pj-rehearse
does not attempt to re-run them either). This change makes the metrics
tool track occurrences of this.
Pre-#144 artifacts cannot be analysed for this purpose, because they did not record SHA of the commit the rehearsals were run for (and statuses are not stale when SHA changes).
Example output:
Related to:
/cc @stevekuznetsov @bbguimaraes @droslean