Skip to content
This repository was archived by the owner on Jun 14, 2019. It is now read-only.

Conversation

@bbguimaraes
Copy link
Contributor

I am still working on templates, as that will require more fundamental changes, but the basic mechanism is already reviewable.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2019
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bbguimaraes you want to make sure this is ready to go for the profiles and then do templates in another PR?

@bbguimaraes
Copy link
Contributor Author

I am considering it. The template changes are almost done, they would make the PR significantly larger and are mostly orthogonal.

It would be nice to get #122 in before this so I can add proper integration tests, I'll take a look and see what's left in there.

@petr-muller
Copy link
Member

LGTM, nice! Would prefer to merge this and have another PR for templates...

@bbguimaraes
Copy link
Contributor Author

Rebased and updated. If you've reviewed this before, I tried to keep the diff to a minimum: check only the last commit. I'll squash when approved. This can be merged as is, but you can also check the template PR:

#146

Main differences from the previous version:

@bbguimaraes
Copy link
Contributor Author

Incorporated @petr-muller's suggestion and added an extra test fix that got lost during the refactorings.

@bbguimaraes
Copy link
Contributor Author

Rebase and squashed.

Some small changes were necessary because of an upstream change to the interface of the updateconfig functions: kubernetes/test-infra@8ca3546.

@bbguimaraes bbguimaraes changed the title [WIP] rehearse: use updateconfig to generate CMs rehearse: use updateconfig to generate CMs Apr 25, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2019
Copy link
Contributor

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bbguimaraes,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0c9f252 into openshift:master Apr 27, 2019
@bbguimaraes bbguimaraes deleted the cm_updateconfig branch April 29, 2019 07:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants