This repository was archived by the owner on Jun 14, 2019. It is now read-only.
The new upgrade job is supported as part of the ci-operator #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarterclayton
requested review from
bbguimaraes,
droslean and
stevekuznetsov
and removed request for
droslean and
stevekuznetsov
openshift-ci-robot
added
the
size/XXL
Contributor
Author
Member
|
@smarterclayton That seems to caused by bumping the ci-operator libraries, |
Contributor
Author
|
Oh, I thought this was rehearsing against the real repositories. Duh, fixing. |
Instead of mounting the template, the ci-operator can run the job itself. Use the upgrade=true flag only to test this logic while we verify that upgrade tests (and their attendant complexity) don't destabilize other jobs.
Contributor
Author
|
Fixed |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of mounting the template, the ci-operator can run the job itself.
Use the upgrade=true flag only to test this logic while we verify that
upgrade tests (and their attendant complexity) don't destabilize other
jobs.
Examples of the job generated by this PR are in openshift/release#3030. Will be testing openshift/ci-operator#288 before we merge