ci-operator: document CLI injection #8
Conversation
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
openshift-ci-robot
added
the
approved
| - as: use-cli | ||
| commands: oc adm policy add-role-to-user --help | ||
| from: os # use the "os" image for running the test | ||
| cli: custom # allow the CLI from the "custom" release to be available |
There was a problem hiding this comment.
Wouldn't it make more sense to use an actual release like "4.6" to clarify that this has to be a release version?
There was a problem hiding this comment.
That is not what this field should be, so no.
There was a problem hiding this comment.
Then I don't understand it. Isn't the purpose of this to inject a oc cli from a specifig release?
There was a problem hiding this comment.
The release is called "custom", as noted in the releases configuration above.
There was a problem hiding this comment.
@alvaroaleman how do I re-test this? |
It seems to be weird sideffect of disabling those. The actual deploy went fine |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This implements DPTP-1242 |
4 participants
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
This implements DPTP-1242
xref openshift/ci-tools#1296