Bug 1866265: Stop Keepalived on bootstrap after bootstrap completed #92
Conversation
openshift-ci-robot
added
the
approved
|
/retitle bug: 1866265 Stop Keepalived on bootstrap after bootstrap completed |
openshift-ci-robot
changed the title
bcrochet
left a comment
bcrochet
left a comment
There was a problem hiding this comment.
Couple of comments, couple of questions.
pkg/monitor/dynkeepalived.go
Outdated
| return updateRequired, desiredModeInfo | ||
| } | ||
|
|
||
| func handleBootstrapApiNA(kubeconfigPath string, bootstrapApiNA chan bool) { |
There was a problem hiding this comment.
It's not immediately apparent what "NA" stands for... It's used a few times here, and I sort of get that it's possibly an error condition, but I'm not totally sure from the context. Can we be more explicit here?
pkg/monitor/dynkeepalived.go
Outdated
| } | ||
| time.Sleep(5 * time.Second) | ||
| } | ||
|
|
yboaron
force-pushed
the
tx_stop_keepalived
branch
from
5b8d80f to
2d36f52
Compare
|
/retest |
yboaron
force-pushed
the
tx_stop_keepalived
branch
from
2d36f52 to
e0a1ba6
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
yboaron
force-pushed
the
tx_stop_keepalived
branch
from
e0a1ba6 to
f25d997
Compare
|
/test e2e-metal-ipi |
When OPENSHIFT_INSTALL_PRESERVE_BOOTSTRAP deployment configuration parameter is set to true the bootstrap node won't be destroyed and the infrastructure components including Keepalived on the bootstrap continue to run. With this PR a stop message is sent to Keepalived control socket when the API server is not operational anymore on bootstrap node. This change is important for platforms that run Keepalived in unicast mode (baremetal).
yboaron
force-pushed
the
tx_stop_keepalived
branch
from
f25d997 to
27266bb
Compare
|
/test e2e-metal-ipi |
1 similar comment
|
/test e2e-metal-ipi |
|
/retitle Bug 1866265: Stop Keepalived on bootstrap after bootstrap completed |
openshift-ci-robot
changed the title
openshift-ci-robot
added
the
bugzilla/severity-low
|
@yboaron: This pull request references Bugzilla bug 1866265, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, yboaron The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yboaron: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1866265 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
When OPENSHIFT_INSTALL_PRESERVE_BOOTSTRAP deployment configuration parameter is set to true the
bootstrap node won't be destroyed and the infrastructure components including Keepalived on the bootstrap continue to run.
With this PR a stop message is sent to Keepalived control socket when the API server is not operational anymore on bootstrap node.
This change is important for platforms that run Keepalived in unicast mode (baremetal).