Use cluster-config.yml first for cluster name and domain #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the cluster-config.yml is passed to runtimecfg, it should use that first, and fall back to kubeconfig to get the cluster name and domain. Fixes openshift#15
openshift-ci-robot
added
the
size/M
bcrochet
added a commit
to bcrochet/machine-config-operator
that referenced
this pull request
Aug 7, 2019
A recent installer change started using a loopback address in kubeconfig as the default on the bootstrap node. baremetal-runtimecfg will begin using cluster-config.yml if it exists first, in order to get the domain and name of the cluster. This patch adds a flag for this to the keepalived bootstrap pod in order to utilize it. This should only affect the bootstrap pods. Fixes openshift#1037 Depends on openshift/baremetal-runtimecfg#16
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bcrochet, celebdor The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the cluster-config.yml is passed to runtimecfg, it should use that
first, and fall back to kubeconfig to get the cluster name and
domain.
Fixes #15