[release-4.9] Bug 2009850: Fix fallback for ironic drivers that don't support soft power off#184
Conversation
The code to check whether a previous PowerOff command succeeded is essentially the same between the hard and soft power off modes, so check it once at the start instead of duplicating it. (cherry picked from commit 9ba2fd2)
If the ironic driver does not support soft power off, we need to fall back to hard power off. Due to an oversight in 67a27dc we stopped checking for this and just returned a transient error in this case. While returning a failure would have resulted in retrying with a hard power off (albeit after reporting an error to the user), returning a transient error means that it will retry the soft power off forever. Restore the fallback and add tests to cover this case. Because we can't set the dummy ironic server to return different responses on subsequent calls we will always get an error, so check that it is from the fallback hard power off. (cherry picked from commit f75c6b7)
openshift-ci
Bot
added
bugzilla/severity-medium
|
@zaneb: This pull request references Bugzilla bug 2009850, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest-required |
|
/bugzilla refresh |
|
@dtantsur: This pull request references Bugzilla bug 2009850, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2009850, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2009850, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2009850, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 2009850, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
Bot
added
the
bugzilla/valid-bug
|
@sdodson: This pull request references Bugzilla bug 2009850, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (augol@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
removed
the
bugzilla/invalid-bug
|
/label backport-risk-assessed |
openshift-ci
Bot
added
the
backport-risk-assessed
stleerh
added
the
cherry-pick-approved
|
@zaneb: All pull requests linked via external trackers have merged: Bugzilla bug 2009850 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6 participants
Fix a regression in metal3-io#841 that caused ironic drivers that don't support soft power off (such as Fujitsu when the agent is not available) to fail in an infinite loop instead of falling back to a hard power off.