Skip to content

Bug 2043130: azure-disk: Add external-snapshotter permissions to patch snapshots#41

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
RomanBednar:add-snapshot-patch
Jan 26, 2022
Merged

Bug 2043130: azure-disk: Add external-snapshotter permissions to patch snapshots#41
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
RomanBednar:add-snapshot-patch

Conversation

@RomanBednar
Copy link
Contributor

The new external-snapshotter needs permissions to Patch VolumeSnapshots and
VolumeSnapshotContents.

https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v5.0.1

The new external-snapshotter needs permissions to Patch VolumeSnapshots and
VolumeSnapshotContents.

https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v5.0.1
@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

@RomanBednar: This pull request references Bugzilla bug 2043130, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

Details

In response to this:

Bug 2043130: azure-disk: Add external-snapshotter permissions to patch snapshots

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 26, 2022
@openshift-ci openshift-ci bot requested review from dobsonj and tsmetana January 26, 2022 10:59
@jsafrane
Copy link
Contributor

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dobsonj
Copy link
Member

dobsonj commented Jan 26, 2022

/retest

@jsafrane
Copy link
Contributor

/override ci/prow/e2e-azurestack-csi
we know it's broken.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

@jsafrane: Overrode contexts on behalf of jsafrane: ci/prow/e2e-azurestack-csi

Details

In response to this:

/override ci/prow/e2e-azurestack-csi
we know it's broken.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 3b25a5d into openshift:master Jan 26, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

@RomanBednar: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2043130 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2043130: azure-disk: Add external-snapshotter permissions to patch snapshots

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

@RomanBednar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 26, 2022

@RomanBednar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants