Skip to content

Comments

Bug 2038934: Add custom CA bundle support#146

Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
jsafrane:add-proxy-ca
Jan 20, 2022
Merged

Bug 2038934: Add custom CA bundle support#146
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
jsafrane:add-proxy-ca

Conversation

@jsafrane
Copy link
Contributor

Add support for proxy CA bundles.
Bump library-go and other dependencies (e.g. Kubernetes libs) and update the operator to it.
cc @openshift/storage

/hold
for openshift/library-go#1282 to get merged

@openshift-ci openshift-ci bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2022

@jsafrane: This pull request references Bugzilla bug 2038934, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (wduan@redhat.com), skipping review request.

Details

In response to this:

Bug 2038934: Add custom CA bundle support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from gnufied and tsmetana January 11, 2022 16:51
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2022
@jsafrane
Copy link
Contributor Author

jsafrane commented Jan 17, 2022

/hold cancel
Updated with today's library-go

@bertinatto
Copy link
Member

/test e2e-aws-csi-migration

[sig-storage]  In-tree Volumes [Driver: aws] [Testpattern: Dynamic PV (default fs)]  subPath should support existing single file [LinuxOnly]  [Suite:openshift/conformance/parallel] [Suite:k8s] expand_less | 6m42s
fail [k8s.io/kubernetes@v1.22.1/test/e2e/framework/util.go:742]: Unexpected error:     <*errors.errorString \| 0xc003080b70>: {         s: "expected pod \"pod-subpath-test-dynamicpv-vnpl\" success: Gave up after waiting 5m0s for pod \"pod-subpath-test-dynamicpv-vnpl\" to be \"Succeeded or Failed\"",     }     expected pod "pod-subpath-test-dynamicpv-vnpl" success: Gave up after waiting 5m0s for pod "pod-subpath-test-dynamicpv-vnpl" to be "Succeeded or Failed" occurred

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 18, 2022

@jsafrane: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gnufied
Copy link
Member

gnufied commented Jan 20, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2022
@openshift-merge-robot openshift-merge-robot merged commit be346e7 into openshift:master Jan 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 20, 2022

@jsafrane: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 2038934 has not been moved to the MODIFIED state.

Details

In response to this:

Bug 2038934: Add custom CA bundle support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants