Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-6806: Enable remote debugging on Beaker hosts #904

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

michaellevy101
Copy link
Contributor

@michaellevy101 michaellevy101 commented Jun 21, 2021

  1. Patch the image with the debug information
  2. Expose debug port in the firewall
  3. Expose debug port in the host (xinit) - Support multiple ports recognition
  4. Enable registry add-on - a completion to NO-ISSUE support using a local registry assisted-service#1611 PR

@openshift-ci openshift-ci bot requested review from romfreiman and YuviGold June 21, 2021 14:20
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2021
@michaellevy101
Copy link
Contributor Author

/hold wait to openshift/assisted-service#2039 PR to be merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 21, 2021
@michaellevy101 michaellevy101 force-pushed the MGMT-6806 branch 2 times, most recently from 8111c2a to 5c6e97c Compare June 21, 2021 16:19
@michaellevy101 michaellevy101 force-pushed the MGMT-6806 branch 4 times, most recently from 8c91227 to 03afbc6 Compare June 23, 2021 13:11
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2021
@michaellevy101
Copy link
Contributor Author

/retest

@michaellevy101
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 23, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1. Patch the image with the debug information
2. Expose debug port in the firewall
3. Expose debug port in the host (xinit) - Support multiple ports recognition
4. Enable registry add-on - a completion to openshift/assisted-service#1611 PR
5. Deploy only a single AI replica
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaellevy101, YuviGold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [YuviGold,michaellevy101]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 046d03d into openshift:master Jun 24, 2021
@michaellevy101 michaellevy101 deleted the MGMT-6806 branch August 25, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants