AGENT-1303: Wait for cluster creation when creating InfraEnv#8007
AGENT-1303: Wait for cluster creation when creating InfraEnv#8007zaneb wants to merge 2 commits intoopenshift:masterfrom
Conversation
The 'register' command has long since been split into separate 'registerCluster' and 'registerInfraEnv' phases, so the duplicate code can be removed.
In an interactive workflow the user interacting with the UI creates the Cluster object in the database; however, we wish to use the same client to register the InfraEnv as in the ABI flow. To enable this, when registering the InfraEnv wait until the Cluster has been created, since in the future this may happen asynchronously. Previously we returned an error and systemd would have restarted the service.
openshift-ci-robot
added
the
jira/valid-reference
|
@zaneb: This pull request references AGENT-1303 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8007 +/- ##
==========================================
+ Coverage 73.68% 73.78% +0.09%
==========================================
Files 400 403 +3
Lines 68657 69155 +498
==========================================
+ Hits 50587 51023 +436
- Misses 15356 15394 +38
- Partials 2714 2738 +24
🚀 New features to boost your workflow:
|
|
@zaneb: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/close |
|
@zaneb: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
When creating the InfraEnv in ABI, instead of exiting with an error if the Cluster has not been created, poll the API until it is. Previously we would exit with an error code and systemd would restart the whole process instead.