Skip to content

MGMT-20893: Remove Remediation operators from virtualization bundle#7795

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
danmanor:remove-remediation-operators-from-virt-bundle
Jun 26, 2025
Merged

MGMT-20893: Remove Remediation operators from virtualization bundle#7795
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
danmanor:remove-remediation-operators-from-virt-bundle

Conversation

@danmanor
Copy link
Contributor

@danmanor danmanor commented Jun 24, 2025

Depend on openshift-assisted/assisted-installer-ui#3014

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 24, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 24, 2025

@danmanor: This pull request references MGMT-20893 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Depend on openshift-assisted/assisted-installer-ui#3014

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danmanor
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2025
@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.37%. Comparing base (eabdf47) to head (230b492).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7795      +/-   ##
==========================================
+ Coverage   73.67%   74.37%   +0.69%     
==========================================
  Files         380      381       +1     
  Lines       67441    70036    +2595     
==========================================
+ Hits        49685    52087    +2402     
- Misses      15059    15191     +132     
- Partials     2697     2758      +61     
Files with missing lines Coverage Δ
...tsremediation/fence_agents_remediation_operator.go 20.00% <ø> (ø)
...ators/nodehealthcheck/node_healthcheck_operator.go 26.66% <ø> (ø)
...fnoderemediation/self_node_remediation_operator.go 20.00% <ø> (ø)

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danmanor
Copy link
Contributor Author

/retest

@openshift-ci openshift-ci bot requested review from carbonin and rccrdpccl June 24, 2025 10:52
@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2025

@danmanor: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/edge-e2e-metal-assisted-virtualization-4-18 230b492 link true /test edge-e2e-metal-assisted-virtualization-4-18

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danmanor
Copy link
Contributor Author

/test edge-e2e-metal-assisted-virtualization-4-18

@openshift-ci
Copy link

openshift-ci bot commented Jun 24, 2025

@danmanor: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test e2e-agent-compact-ipv4
/test edge-assisted-operator-catalog-publish-verify
/test edge-ci-index
/test edge-e2e-ai-operator-disconnected-capi
/test edge-e2e-ai-operator-ztp
/test edge-e2e-ai-operator-ztp-3masters
/test edge-e2e-ai-operator-ztp-capi
/test edge-e2e-ai-operator-ztp-disconnected
/test edge-e2e-metal-assisted-4-14
/test edge-e2e-metal-assisted-4-15
/test edge-e2e-metal-assisted-4-16
/test edge-e2e-metal-assisted-4-17
/test edge-e2e-metal-assisted-4-19
/test edge-e2e-metal-assisted-5-control-planes-4-19
/test edge-e2e-metal-assisted-ai-amd-4-19
/test edge-e2e-metal-assisted-ai-nvidia-4-19
/test edge-e2e-metal-assisted-external-4-19
/test edge-e2e-metal-assisted-lvm-4-19
/test edge-e2e-metal-assisted-none-4-19
/test edge-e2e-metal-assisted-osc-4-19
/test edge-e2e-metal-assisted-virtualization-4-19
/test edge-e2e-nutanix-assisted-2workers-4-19
/test edge-e2e-nutanix-assisted-4-19
/test edge-e2e-vsphere-assisted-4-19
/test edge-images
/test edge-lint
/test edge-operator-publish-verify
/test edge-subsystem-aws
/test edge-subsystem-kubeapi-aws
/test edge-unit-test
/test edge-verify-generated-code
/test images
/test mce-images
/test verify-deps

The following commands are available to trigger optional jobs:

/test e2e-agent-4control-ipv4
/test e2e-agent-5control-ipv4
/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv6
/test edge-e2e-ai-operator-ztp-4masters
/test edge-e2e-ai-operator-ztp-5masters
/test edge-e2e-ai-operator-ztp-compact-day2-masters
/test edge-e2e-ai-operator-ztp-compact-day2-workers
/test edge-e2e-ai-operator-ztp-multiarch-3masters-ocp
/test edge-e2e-ai-operator-ztp-multiarch-sno-ocp
/test edge-e2e-ai-operator-ztp-node-labels
/test edge-e2e-ai-operator-ztp-remove-node
/test edge-e2e-ai-operator-ztp-sno-day2-masters
/test edge-e2e-ai-operator-ztp-sno-day2-workers
/test edge-e2e-ai-operator-ztp-sno-day2-workers-ignitionoverride
/test edge-e2e-ai-operator-ztp-sno-day2-workers-late-binding
/test edge-e2e-metal-assisted-4-control-planes-4-19
/test edge-e2e-metal-assisted-4-masters-none-4-19
/test edge-e2e-metal-assisted-bond-4-14
/test edge-e2e-metal-assisted-bond-4-19
/test edge-e2e-metal-assisted-day2-4-19
/test edge-e2e-metal-assisted-day2-arm-workers-4-19
/test edge-e2e-metal-assisted-day2-sno-4-19
/test edge-e2e-metal-assisted-ha-kube-api-ipv4-4-19
/test edge-e2e-metal-assisted-ha-kube-api-ipv6-4-19
/test edge-e2e-metal-assisted-ipv4v6-4-19
/test edge-e2e-metal-assisted-ipv6-4-19
/test edge-e2e-metal-assisted-kube-api-late-binding-sno-4-19
/test edge-e2e-metal-assisted-kube-api-late-unbinding-sno-4-19
/test edge-e2e-metal-assisted-kube-api-umlb-4-19
/test edge-e2e-metal-assisted-onprem-4-19
/test edge-e2e-metal-assisted-osc-sno-4-19
/test edge-e2e-metal-assisted-sno-4-19
/test edge-e2e-metal-assisted-static-ip-suite-4-14
/test edge-e2e-metal-assisted-static-ip-suite-4-19
/test edge-e2e-metal-assisted-tang-4-19
/test edge-e2e-metal-assisted-tpmv2-4-19
/test edge-e2e-metal-assisted-umlb-4-19
/test edge-e2e-metal-assisted-upgrade-agent-4-19
/test edge-e2e-oci-assisted-4-19
/test edge-e2e-oci-assisted-bm-iscsi-4-19
/test edge-e2e-vsphere-assisted-umlb-4-19
/test edge-e2e-vsphere-assisted-umn-4-19
/test okd-scos-e2e-aws-ovn
/test okd-scos-images
/test push-pr-image

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-assisted-service-master-e2e-agent-compact-ipv4
pull-ci-openshift-assisted-service-master-edge-ci-index
pull-ci-openshift-assisted-service-master-edge-e2e-ai-operator-ztp
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-4-19
pull-ci-openshift-assisted-service-master-edge-e2e-metal-assisted-virtualization-4-19
pull-ci-openshift-assisted-service-master-edge-images
pull-ci-openshift-assisted-service-master-edge-lint
pull-ci-openshift-assisted-service-master-edge-subsystem-aws
pull-ci-openshift-assisted-service-master-edge-subsystem-kubeapi-aws
pull-ci-openshift-assisted-service-master-edge-unit-test
pull-ci-openshift-assisted-service-master-edge-verify-generated-code
pull-ci-openshift-assisted-service-master-images
pull-ci-openshift-assisted-service-master-mce-images
pull-ci-openshift-assisted-service-master-okd-scos-e2e-aws-ovn
pull-ci-openshift-assisted-service-master-verify-deps
Details

In response to this:

/test edge-e2e-metal-assisted-virtualization-4-18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danmanor
Copy link
Contributor Author

/override ci/prow/edge-e2e-metal-assisted-virtualization-4-18

@openshift-ci
Copy link

openshift-ci bot commented Jun 25, 2025

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/edge-e2e-metal-assisted-virtualization-4-18

Details

In response to this:

/override ci/prow/edge-e2e-metal-assisted-virtualization-4-18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danmanor
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 25, 2025

@danmanor: This pull request references MGMT-20893 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Depend on openshift-assisted/assisted-installer-ui#3014

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 25, 2025

@danmanor: This pull request references MGMT-20893 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Depend on openshift-assisted/assisted-installer-ui#3014

List all the issues related to this PR

  • New Feature
  • Enhancement
  • Bug fix
  • Tests
  • Documentation
  • CI/CD

What environments does this code impact?

  • Automation (CI, tools, etc)
  • Cloud
  • Operator Managed Deployments
  • None

How was this code tested?

  • assisted-test-infra environment
  • dev-scripts environment
  • Reviewer's test appreciated
  • Waiting for CI to do a full test run
  • Manual (Elaborate on how it was tested)
  • No tests needed

Checklist

  • Title and description added to both, commit and PR.
  • Relevant issues have been associated (see CONTRIBUTING guide)
  • This change does not require a documentation update (docstring, docs, README, etc)
  • Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

  • Are the title and description (in both PR and commit) meaningful and clear?
  • Is there a bug required (and linked) for this change?
  • Should this PR be backported?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pastequo
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d5e132e and 2 for PR HEAD 230b492 in total

@danmanor
Copy link
Contributor Author

/override ci/prow/edge-subsystem-kubeapi-aws

@openshift-ci
Copy link

openshift-ci bot commented Jun 25, 2025

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/edge-subsystem-kubeapi-aws

Details

In response to this:

/override ci/prow/edge-subsystem-kubeapi-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danmanor
Copy link
Contributor Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3176cb3 and 1 for PR HEAD 230b492 in total

@openshift-merge-bot openshift-merge-bot bot merged commit ed6635b into openshift:master Jun 26, 2025
23 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-api-server
This PR has been included in build ose-agent-installer-api-server-container-v4.20.0-202506260543.p0.ged6635b.assembly.stream.el9.
All builds following this will include this PR.

@danmanor
Copy link
Contributor Author

/cherry-pick release-4.19

@openshift-cherrypick-robot

@danmanor: new pull request created: #7814

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants