Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.18] OCPBUGS-45183: Add NTP sources to generated install-config.yaml #7037

Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from
Open

[release-4.18] OCPBUGS-45183: Add NTP sources to generated install-config.yaml #7037

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #7028

/assign zaneb

@jhernand
OCPBUGS-44882: Add NTP sources to generated install-config.yaml
1d0a2fd 
In OpenShift 4.18 a new `additionalNTPServers` field was added to the
baremetal platform section of the `install-config.yaml` file . This
needs to be populated with the NTP sources provided by the user in order
to correctly set time before installation of new nodes using the
baremetal provisioning flow.

Related: https://issues.redhat.com/browse/OCPBUGS-44882
Signed-off-by: Juan Hernandez <[email protected]>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 28, 2024
Merged
20 tasks
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-44882 has been cloned as Jira Issue OCPBUGS-45183. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-45183: Add NTP sources to generated install-config.yaml

In response to this:

This is an automated cherry-pick of #7028

/assign zaneb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-44882: Add NTP sources to generated install-config.yaml [release-4.18] OCPBUGS-45183: Add NTP sources to generated install-config.yaml Nov 28, 2024
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 28, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Nov 28, 2024
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-45183, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #7028

/assign zaneb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 28, 2024
@zaneb
Copy link
Member

zaneb commented Nov 29, 2024

/approve
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 29, 2024
@jhernand
Copy link
Contributor

jhernand commented Dec 2, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2024
@jhernand
Copy link
Contributor

jhernand commented Dec 3, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2024
@jhernand
Copy link
Contributor

jhernand commented Dec 3, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 3, 2024
@openshift-ci-robot
Copy link

@jhernand: This pull request references Jira Issue OCPBUGS-45183, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-44882 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-44882 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 3, 2024
@jhernand
Copy link
Contributor

jhernand commented Dec 3, 2024

@zaneb this pull request is only missing the cherry-pick-approved label. I guess I won't have permission to add it. Do you?

@paul-maidment
Copy link
Contributor

/lgtm
Looks good, appears to be a backport of an already merged PR

@paul-maidment
Copy link
Contributor

/test okd-scos-images

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 10, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@paul-maidment
Copy link
Contributor

/lgtm
Looks like a backport of an already merged change

paul-maidment
paul-maidment approved these changes Dec 15, 2024
View reviewed changes
Copy link
Contributor

@paul-maidment paul-maidment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (is backport of pre-existing merged change)

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhernand, openshift-cherrypick-robot, paul-maidment, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jhernand,paul-maidment]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zaneb
Copy link
Member

zaneb commented Dec 15, 2024

ABI QE can add cherry-pick-approved
/cc @mhanss

@openshift-ci openshift-ci bot requested a review from mhanss December 15, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paul-maidment paul-maidment paul-maidment approved these changes

@avishayt avishayt Awaiting requested review from avishayt

@mhanss mhanss Awaiting requested review from mhanss

Assignees

@zaneb zaneb

@jhernand jhernand

@paul-maidment paul-maidment

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @zaneb @jhernand @paul-maidment