-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-18230: Bump to go version 1.22 #7011
base: master
Are you sure you want to change the base?
Conversation
@paul-maidment: This pull request references MGMT-18230 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, paul-maidment The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In order to address a number of CVE's, a go version bump to v1.22 is recommended. This PR changes to go version v1.22
a0b65b8
to
acdf655
Compare
New changes are detected. LGTM label has been removed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7011 +/- ##
==========================================
+ Coverage 68.31% 74.61% +6.29%
==========================================
Files 272 324 +52
Lines 38885 63167 +24282
==========================================
+ Hits 26565 47132 +20567
- Misses 9922 13563 +3641
- Partials 2398 2472 +74 |
/retest |
maybe we should update the other packages - cause you may have some issues between them |
@@ -1,6 +1,6 @@ | |||
module github.com/openshift/assisted-service | |||
|
|||
go 1.21 | |||
go 1.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when updating the go version you should also update the linter - you may have issues if the linter is not aligned
https://github.com/paul-maidment/assisted-service/blob/MGMT-18230/ci-images/Dockerfile.lint#L3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! I missed this one, thanks for the pointer.
@paul-maidment: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
In order to address a number of CVE's, a go version bump to v1.22 is recommended. This PR changes to go version v1.22
List all the issues related to this PR
What environments does this code impact?
How was this code tested?
Checklist
docs
, README, etc)Reviewers Checklist